Skip to content

deduplication memory fixes #22532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Aug 7, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

github-actions bot commented Aug 7, 2025

🟢 2025-08-07 15:10:29 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Aug 7, 2025

2025-08-07 15:12:51 UTC Pre-commit check linux-x86_64-release-asan for 04c20b5 has started.
2025-08-07 15:13:05 UTC Artifacts will be uploaded here
2025-08-07 15:16:48 UTC ya make is running...
🟡 2025-08-07 17:50:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16836 16399 0 107 306 24

🟢 2025-08-07 17:51:49 UTC Build successful.
🟢 2025-08-07 17:52:18 UTC ydbd size 4.0 GiB changed* by +35.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 47f183f merge: 04c20b5 diff diff %
ydbd size 4 247 837 272 Bytes 4 247 874 040 Bytes +35.9 KiB +0.001%
ydbd stripped size 1 469 922 040 Bytes 1 469 940 184 Bytes +17.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 7, 2025

2025-08-07 15:13:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 04c20b5 has started.
2025-08-07 15:14:13 UTC Artifacts will be uploaded here
2025-08-07 15:17:56 UTC ya make is running...
🟡 2025-08-07 17:17:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39419 36633 0 8 2750 28

2025-08-07 17:20:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-07 17:34:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1174 (only retried tests) 1103 0 1 50 20

2025-08-07 17:34:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-07 17:46:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
668 (only retried tests) 597 0 1 50 20

🟢 2025-08-07 17:46:42 UTC Build successful.
🟢 2025-08-07 17:47:02 UTC ydbd size 2.2 GiB changed* by +16.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 47f183f merge: 04c20b5 diff diff %
ydbd size 2 414 537 464 Bytes 2 414 554 576 Bytes +16.7 KiB +0.001%
ydbd stripped size 504 890 664 Bytes 504 897 768 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2025

2025-08-08 07:27:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc9924d has started.
2025-08-08 07:27:41 UTC Artifacts will be uploaded here
2025-08-08 07:31:36 UTC ya make is running...
🟡 2025-08-08 09:34:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39441 36637 0 4 2759 41

2025-08-08 09:38:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-08 09:54:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1380 (only retried tests) 1304 0 0 53 23

🟢 2025-08-08 09:54:26 UTC Build successful.
🟢 2025-08-08 09:54:49 UTC ydbd size 2.2 GiB changed* by +12.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 546769d merge: cc9924d diff diff %
ydbd size 2 414 813 432 Bytes 2 414 826 480 Bytes +12.7 KiB +0.001%
ydbd stripped size 504 942 632 Bytes 504 945 672 Bytes +3.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2025

2025-08-08 07:27:24 UTC Pre-commit check linux-x86_64-release-asan for cc9924d has started.
2025-08-08 07:27:40 UTC Artifacts will be uploaded here
2025-08-08 07:31:39 UTC ya make is running...
🟡 2025-08-08 10:19:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16854 16332 0 187 313 22

🟢 2025-08-08 10:20:44 UTC Build successful.
🟢 2025-08-08 10:21:12 UTC ydbd size 4.0 GiB changed* by +32.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 546769d merge: cc9924d diff diff %
ydbd size 4 248 374 976 Bytes 4 248 407 736 Bytes +32.0 KiB +0.001%
ydbd stripped size 1 470 078 744 Bytes 1 470 092 856 Bytes +13.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review August 8, 2025 08:23
@swalrus1 swalrus1 requested a review from a team as a code owner August 8, 2025 08:23
@swalrus1 swalrus1 enabled auto-merge (squash) August 8, 2025 09:03
@swalrus1 swalrus1 merged commit a798aa2 into ydb-platform:main Aug 8, 2025
12 checks passed
@swalrus1 swalrus1 deleted the deduplication-memory branch August 8, 2025 10:46
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Aug 14, 2025
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants