Skip to content

YQ-4257 Added FlagTrackDelivery to StatusTracker #22543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

YQ-4257 Added FlagTrackDelivery to StatusTracker #22543

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22eec50
add FlagTrackDelivery
kardymonds Aug 7, 2025
9892962
add comment
kardymonds Aug 7, 2025
bacb1af
fix IsSuccess
kardymonds Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ydb/core/fq/libs/compute/ydb/status_tracker_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class TStatusTrackerActor : public TBaseComputeActor<TStatusTrackerActor> {
STRICT_STFUNC(StateFunc,
hFunc(TEvYdbCompute::TEvGetOperationResponse, Handle);
hFunc(TEvents::TEvForwardPingResponse, Handle);
hFunc(NActors::TEvents::TEvUndelivered, Handle);
)

void Handle(const TEvents::TEvForwardPingResponse::TPtr& ev) {
Expand Down Expand Up @@ -231,7 +232,7 @@ class TStatusTrackerActor : public TBaseComputeActor<TStatusTrackerActor> {
GetStepCountersSubgroup()->GetCounter("StatIssues", true)->Inc();
}
ReportPublicCounters(Builder.PublicStat);
Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest), 0, 1);
Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest), IEventHandle::FlagTrackDelivery, 1);
}

void UpdateCpuQuota(double cpuUsage) {
Expand All @@ -254,7 +255,7 @@ class TStatusTrackerActor : public TBaseComputeActor<TStatusTrackerActor> {
ReportPublicCounters(Builder.PublicStat);
UpdateCpuQuota(Builder.CpuUsage);

Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest));
Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest), IEventHandle::FlagTrackDelivery);
}

void Complete() {
Expand All @@ -270,7 +271,14 @@ class TStatusTrackerActor : public TBaseComputeActor<TStatusTrackerActor> {
ReportPublicCounters(Builder.PublicStat);
UpdateCpuQuota(Builder.CpuUsage);

Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest));
Send(Pinger, new TEvents::TEvForwardPingRequest(pingTaskRequest), IEventHandle::FlagTrackDelivery);
}

void Handle(NActors::TEvents::TEvUndelivered::TPtr& ev) {
// Pinger may end (with ydb_run_actor); no one sends a poison pill to this status tracker.
// Therefore we'll finish ourselves.
LOG_W("TEvUndelivered, from " << ev->Sender << ", reason " << ev->Get()->Reason);
FailedAndPassAway();
}

private:
Expand Down
Loading