Skip to content

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

#25524

Changelog category

  • Bugfix

Description for reviewers

При создании changefeed проверяетеся первый компонент первичного ключа, если он не Uint32 или Uint64, то настройки партиционирования не заполняются

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:06:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for a58f09e has started.
2025-09-22 14:07:12 UTC Artifacts will be uploaded here
2025-09-22 14:09:07 UTC Check cancelled

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:06:56 UTC Pre-commit check linux-x86_64-release-asan for a58f09e has started.
2025-09-22 14:07:10 UTC Artifacts will be uploaded here
2025-09-22 14:09:07 UTC Check cancelled

Copy link

🟢 2025-09-22 14:08:48 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:10:34 UTC Pre-commit check linux-x86_64-release-asan for d26caff has started.
2025-09-22 14:10:38 UTC Artifacts will be uploaded here
2025-09-22 14:14:08 UTC ya make is running...
2025-09-22 14:16:32 UTC Check cancelled

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:10:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for d26caff has started.
2025-09-22 14:10:53 UTC Artifacts will be uploaded here
2025-09-22 14:14:28 UTC ya make is running...
2025-09-22 14:16:31 UTC Check cancelled

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug related to importing tables with changefeed where partitioning settings are not properly applied when the primary key type is not Uint32 or Uint64. The fix ensures that changefeed partitioning configuration is only applied for tables with supported primary key types.

  • Added logic to check the primary key type before applying partitioning settings in changefeed creation
  • Enhanced test coverage to verify proper behavior for different primary key types
  • Added new test helper functions to validate topic partitioning settings

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
ydb/core/tx/schemeshard/schemeshard_import_flow_proposals.cpp Added primary key type validation to conditionally apply partitioning settings
ydb/core/tx/schemeshard/ut_restore/ut_restore.cpp Enhanced test framework with primary key type parameters and added specific tests for partitioning behavior
ydb/core/tx/schemeshard/ut_helpers/ls_checks.h Added new helper function declarations for topic partition validation
ydb/core/tx/schemeshard/ut_helpers/ls_checks.cpp Implemented new helper functions to check topic partition count settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:17:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0134b53 has started.
2025-09-22 14:18:04 UTC Artifacts will be uploaded here
2025-09-22 14:21:37 UTC ya make is running...
🟡 2025-09-22 16:30:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38379 35612 0 2 2736 29

2025-09-22 16:34:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-22 16:44:31 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 197 0 0 0 19

🟢 2025-09-22 16:44:38 UTC Build successful.
🟢 2025-09-22 16:44:54 UTC ydbd size 2.3 GiB changed* by +3.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b1b3841 merge: 0134b53 diff diff %
ydbd size 2 430 261 160 Bytes 2 430 264 984 Bytes +3.7 KiB +0.000%
ydbd stripped size 520 687 496 Bytes 520 687 880 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:18:05 UTC Pre-commit check linux-x86_64-release-asan for 0134b53 has started.
2025-09-22 14:18:19 UTC Artifacts will be uploaded here
2025-09-22 14:21:56 UTC ya make is running...
🟡 2025-09-22 16:57:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15489 15082 0 119 259 29

🟢 2025-09-22 16:59:08 UTC Build successful.
🟢 2025-09-22 16:59:32 UTC ydbd size 3.8 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b1b3841 merge: 0134b53 diff diff %
ydbd size 4 043 419 608 Bytes 4 043 423 112 Bytes +3.4 KiB +0.000%
ydbd stripped size 1 506 339 904 Bytes 1 506 341 120 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 23, 2025

2025-09-23 08:39:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 833267e has started.
2025-09-23 08:40:10 UTC Artifacts will be uploaded here
2025-09-23 08:44:24 UTC ya make is running...
🟡 2025-09-23 10:07:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38393 35620 0 1 2742 30

2025-09-23 10:08:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-23 10:25:23 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
567 (only retried tests) 546 0 0 0 21

🟢 2025-09-23 10:25:26 UTC Build successful.
🟡 2025-09-23 10:25:43 UTC ydbd size 2.3 GiB changed* by +282.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8a5bb85 merge: 833267e diff diff %
ydbd size 2 430 481 784 Bytes 2 430 770 680 Bytes +282.1 KiB +0.012%
ydbd stripped size 520 714 568 Bytes 520 775 944 Bytes +59.9 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 23, 2025

2025-09-23 08:48:27 UTC Pre-commit check linux-x86_64-release-asan for 833267e has started.
2025-09-23 08:48:45 UTC Artifacts will be uploaded here
2025-09-23 08:52:16 UTC ya make is running...
🟡 2025-09-23 10:47:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15503 15148 0 105 219 31

🟢 2025-09-23 10:47:36 UTC Build successful.
🟢 2025-09-23 10:47:58 UTC ydbd size 3.8 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0789aee merge: 833267e diff diff %
ydbd size 4 044 396 496 Bytes 4 044 400 360 Bytes +3.8 KiB +0.000%
ydbd stripped size 1 506 721 120 Bytes 1 506 722 528 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@stanislav-shchetinin stanislav-shchetinin merged commit 910acf1 into ydb-platform:main Sep 23, 2025
14 checks passed
stanislav-shchetinin added a commit to stanislav-shchetinin/ydb that referenced this pull request Sep 23, 2025
stanislav-shchetinin added a commit to stanislav-shchetinin/ydb that referenced this pull request Sep 23, 2025
stanislav-shchetinin added a commit to stanislav-shchetinin/ydb that referenced this pull request Sep 23, 2025
stanislav-shchetinin added a commit to stanislav-shchetinin/ydb that referenced this pull request Sep 23, 2025
AlexanderShprot pushed a commit to AlexanderShprot/ydb that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when importing a table with a Utf8 primary key and a changefeed
3 participants