-
Notifications
You must be signed in to change notification settings - Fork 723
Fix bug when importing a table with a non Uint primary key and a changefeed #25528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when importing a table with a non Uint primary key and a changefeed #25528
Conversation
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug related to importing tables with changefeed where partitioning settings are not properly applied when the primary key type is not Uint32 or Uint64. The fix ensures that changefeed partitioning configuration is only applied for tables with supported primary key types.
- Added logic to check the primary key type before applying partitioning settings in changefeed creation
- Enhanced test coverage to verify proper behavior for different primary key types
- Added new test helper functions to validate topic partitioning settings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
ydb/core/tx/schemeshard/schemeshard_import_flow_proposals.cpp |
Added primary key type validation to conditionally apply partitioning settings |
ydb/core/tx/schemeshard/ut_restore/ut_restore.cpp |
Enhanced test framework with primary key type parameters and added specific tests for partitioning behavior |
ydb/core/tx/schemeshard/ut_helpers/ls_checks.h |
Added new helper function declarations for topic partition validation |
ydb/core/tx/schemeshard/ut_helpers/ls_checks.cpp |
Implemented new helper functions to check topic partition count settings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
#25524
Changelog category
Description for reviewers
При создании changefeed проверяетеся первый компонент первичного ключа, если он не Uint32 или Uint64, то настройки партиционирования не заполняются