Skip to content

Conversation

dahbka-lis
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR copies arrow helpers used for building ResultSet to KQP (Kernel Query Processor). The changes focus on moving utility functions from DQ to KQP for handling arrow-based result set operations.

  • Moves and refactors arrow helpers functionality from DQ runtime to KQP
  • Cleans up test code by removing unused functionality
  • Simplifies arrow conversion logic with a more focused approach

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.

File Description
ydb/library/yql/dq/runtime/dq_arrow_helpers_ut.cpp Removed arrow conversion test code and simplified basic type testing
ydb/core/kqp/common/result_set_format/* Added new arrow helpers and result set format utilities for KQP
ydb/core/kqp/runtime/kqp_transport.cpp Simplified by delegating to new result set builders
Multiple *.cpp and *.h files Updated imports and type references to use new KQP arrow helpers
Comments suppressed due to low confidence (1)

ydb/library/yql/dq/runtime/dq_arrow_helpers_ut.cpp:1

  • The test assertions check field types but don't verify the field values. Consider adding assertions to validate that the actual data stored in these fields is correct.
#include "dq_arrow_helpers.h"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

🟢 2025-09-22 14:27:48 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:27:51 UTC Pre-commit check linux-x86_64-release-asan for 1d0b0ba has started.
2025-09-22 14:28:06 UTC Artifacts will be uploaded here
2025-09-22 14:31:57 UTC ya make is running...
🟡 2025-09-22 17:12:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17419 16986 0 132 271 30

🟢 2025-09-22 17:14:02 UTC Build successful.
🟡 2025-09-22 17:14:25 UTC ydbd size 3.8 GiB changed* by +461.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b1b3841 merge: 1d0b0ba diff diff %
ydbd size 4 043 419 608 Bytes 4 043 892 048 Bytes +461.4 KiB +0.012%
ydbd stripped size 1 506 339 904 Bytes 1 506 525 792 Bytes +181.5 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 22, 2025

2025-09-22 14:29:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1d0b0ba has started.
2025-09-22 14:29:51 UTC Artifacts will be uploaded here
2025-09-22 14:33:41 UTC ya make is running...
🟡 2025-09-22 16:39:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40317 37555 0 1 2728 33

2025-09-22 16:43:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-22 16:56:17 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 242 0 0 0 21

🟢 2025-09-22 16:56:25 UTC Build successful.
🟡 2025-09-22 16:56:42 UTC ydbd size 2.3 GiB changed* by +207.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b1b3841 merge: 1d0b0ba diff diff %
ydbd size 2 430 261 160 Bytes 2 430 473 632 Bytes +207.5 KiB +0.009%
ydbd stripped size 520 687 496 Bytes 520 731 592 Bytes +43.1 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@kunga kunga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tx/datashard ok

@dahbka-lis dahbka-lis merged commit 1cf5f64 into ydb-platform:main Sep 23, 2025
17 checks passed
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Sep 24, 2025
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Sep 24, 2025
AlexanderShprot pushed a commit to AlexanderShprot/ydb that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants