-
Notifications
You must be signed in to change notification settings - Fork 727
Copy arrow helpers for building ResultSet to KQP #25531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy arrow helpers for building ResultSet to KQP #25531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR copies arrow helpers used for building ResultSet to KQP (Kernel Query Processor). The changes focus on moving utility functions from DQ to KQP for handling arrow-based result set operations.
- Moves and refactors arrow helpers functionality from DQ runtime to KQP
- Cleans up test code by removing unused functionality
- Simplifies arrow conversion logic with a more focused approach
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
ydb/library/yql/dq/runtime/dq_arrow_helpers_ut.cpp | Removed arrow conversion test code and simplified basic type testing |
ydb/core/kqp/common/result_set_format/* | Added new arrow helpers and result set format utilities for KQP |
ydb/core/kqp/runtime/kqp_transport.cpp | Simplified by delegating to new result set builders |
Multiple *.cpp and *.h files | Updated imports and type references to use new KQP arrow helpers |
Comments suppressed due to low confidence (1)
ydb/library/yql/dq/runtime/dq_arrow_helpers_ut.cpp:1
- The test assertions check field types but don't verify the field values. Consider adding assertions to validate that the actual data stored in these fields is correct.
#include "dq_arrow_helpers.h"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🟢 |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tx/datashard ok
Changelog entry
...
Changelog category
Description for reviewers
...