EXT-1423 audit trace merge stream-nb-25-1 #25948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category
Description for reviewers
Problem
The
lwtrace
endpoints currently requires no authorization.The
lwtrace
interface is available through the Developer UI, which is not available for users withoutMonitoringAllowedSIDs
list.The issue was discovered while adding audit logs. Noticed that we don't populate
subject
field with theuserSID
for/trace
endpoint.Limitations of lwtrace
The
/trace
page is registered as an index page by callingNLwTraceMonPage::RegisterPages(IndexMonPage.Get())
. Currently each type of endpoint has its own authorization with significant duplication, but index pages no authorization mechanism, and you cannot assign access rights during registration.Solution: Adding an index-paged service with handler authorization
New instance of
THttpMonIndexService
service has been added. It is used to handle index pages that require authorization.An index page path can be registered as an actor handler with the required permissions specified (currently added only for lwtrace). After authorization, the index page will be processed as before.
Scope
The changes affect only
/trace
handler and/ydb/core/mon
service.audit log example