This repository was archived by the owner on Mar 26, 2018. It is now read-only.
fixes 252 The require.js version doesn't generate tests. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mteodori
force-pushed
the
issue-252
branch
2 times, most recently
from
0865980 to
cb8f58a
Compare
| 'jst_path': this.jst_path | ||
| }); | ||
|
|
||
| if (!this.options.requirejs) { |
There was a problem hiding this comment.
why only this if block stay? is it an exception or was it forgotten here?
There was a problem hiding this comment.
it's ok, script block for files should be added to index.html only if requirejs is not being used, I was implementing it also for test/index.html but the function to insert the script blocks is a bit fragile as it requires a good placeholder and it inserts before that rather than after and that made everything difficult as the file test/index.html comes from generator-mocha
|
Thank you very much for the fix+refactor, this is looking awesome 😄 |
|
oops, looks like this one needs a rebase now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.