Typecast for array presentation #491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
============================================
+ Coverage 95.60% 95.74% +0.13%
Complexity 656 656
============================================
Files 41 42 +1
Lines 1617 1621 +4
============================================
+ Hits 1546 1552 +6
+ Misses 71 69 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tigrov
approved these changes
Oct 29, 2025
src/ActiveQuery.php
Outdated
|
|
||
| /** | ||
| * @psalm-param array<string, mixed> $row | ||
| * @psalm-return ActiveRecordInterface|array<string, mixed> |
There was a problem hiding this comment.
Maybe declare psalm type for ActiveRecordInterface|array<string, mixed>
tests/ActiveRecordTest.php
Outdated
Comment on lines
1192
to
1194
| if (in_array(self::db()->getDriverName(), ['oci', 'sqlsrv'], true)) { | ||
| $this->markTestSkipped('Oracle and MSSQL drivers do not support JSON columns.'); | ||
| } |
There was a problem hiding this comment.
For Oracle and MSSQL should also work
There was a problem hiding this comment.
Done.
Skip only testLazyRelationViaJson because MSSQL and ORACLE don't support "JSON OVERLAPS"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait yiisoft/db#1085