Add semicolon to each statement while dumping the database #33
+26
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
reviewed
Feb 13, 2024
|
|
||
| if ($statements !== []) { | ||
| $file .= PHP_EOL . $statements[0]['query']; | ||
| $file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';'); |
Collaborator
There was a problem hiding this comment.
ends_with will never work as the helper isn't installed in all applications with Laravel.
Collaborator
There was a problem hiding this comment.
Suggested change
| $file .= PHP_EOL . $statements[0]['query'] .(ends_with(trim($statements[0]['query']), ';') ? '' : ';'); | |
| $file .= PHP_EOL . Str::finish($statements[0]['query'], ';'); |
And import use Illuminate\Support\Str;
peterfox
requested changes
Feb 13, 2024
Collaborator
peterfox
left a comment
peterfox
left a comment
There was a problem hiding this comment.
I'm not sure how this didn't come up in development. Could you share an example file output with the problem and what version of Laravel/CockroachDB you're using?
Add illuminate/contracts ^12.0 constraint to enable compatibility with Laravel 12.x framework while maintaining backward compatibility with Laravel 9, 10, and 11. This preserves the custom semicolon fix for schema dumps (commit a94c0d4) which is not present in upstream ylsideas/cockroachdb-laravel. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Pass connection instance to QueryGrammar and SchemaGrammar constructors to support Laravel 12 requirement while maintaining backward compatibility with Laravel 11. Co-authored-by: lucacri <[email protected]>
…8e9d-ef32-48c5-96a8-61560486375a fix: Pass connection to Grammar constructors for Laravel 12 compatibility
…atibility Co-authored-by: lucacri <[email protected]>
…cf5b-52c8-4759-85cc-fe16b804de7b Fix Laravel 12 compatibility: update Grammar initialization pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes In Code
I added a check to see if the statement is ending with a semicolon. If not, it'll add it so that the .sql file generated is going to work also from the
cockroach sqlcommand