Update Logical Backup environment variables for GCP and Azure #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2022 18:31
rocket357
requested review from
CyberDem0n,
FxKu,
Jan-M,
jopadi and
sdudoladov
as code owners
FxKu
reviewed
Apr 13, 2022
| gcc \ | ||
| libffi-dev \ | ||
| nodejs \ | ||
| npm \ |
Member
There was a problem hiding this comment.
hm ins't there another CLI we can use to avoid these dependencies? What about az?
FxKu
reviewed
Apr 13, 2022
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_S3_RETENTION_TIME", Value: c.OpConfig.LogicalBackup.LogicalBackupS3RetentionTime}) | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_S3_BUCKET_SCOPE_SUFFIX", Value: getBucketScopeSuffix(string(c.Postgresql.GetUID()))}) | ||
| } else if c.OpConfig.LogicalBackup.LogicalBackupProvider == "google" || c.OpConfig.LogicalBackup.LogicalBackupProvider == "gcs" { | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_GS_BUCKET", Value: c.OpConfig.LogicalBackup.LogicalBackupGSBucket}) |
Member
There was a problem hiding this comment.
This option does not exists. You have to implement support.
FxKu
reviewed
Apr 13, 2022
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_GOOGLE_APPLICATION_CREDENTIALS", Value: c.OpConfig.LogicalBackup.LogicalBackupGoogleApplicationCredentials}) | ||
| } else if c.OpConfig.LogicalBackup.LogicalBackupProvider == "azure" { | ||
| // assumes logical backups are going to the same place as wal archives. | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_AZ_BUCKET", Value: c.OpConfig.LogicalBackup.LogicalBackupAZBucket}) |
Member
There was a problem hiding this comment.
See my comment on LogicalBackupGSBucket
FxKu
reviewed
Apr 13, 2022
| // assumes logical backups are going to the same place as wal archives. | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_AZ_BUCKET", Value: c.OpConfig.LogicalBackup.LogicalBackupAZBucket}) | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_AZ_BUCKET_SCOPE_SUFFIX", Value: getBucketScopeSuffix(string(c.Postgresql.GetUID()))}) | ||
| envVars = append(envVars, v1.EnvVar{Name: "LOGICAL_BACKUP_AZ_STORAGE_ACCOUNT", Value: c.OpConfig.WALAZStorageAccount}) |
Member
There was a problem hiding this comment.
You should not reuse the storage account you use for WAL backups. There should be a LogicalBackupAZStorageAccount option.
Member
|
@FxKu lets see if we can merge or support this. supporting all platforms sounds like a good motivator |
Member
|
with #2052 merged, I think we can close this. Might be a little confusing now to have explicit options for Azure but for AWS and GCS one has to use the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1838
Update logical backup environment variables for GCP and Azure. I've also added azbak (we've been using in production for 6+ months now) in the example logical-backup image to allow for logical backups within azure, and added azure_upload to dump.sh.