Skip to content

polish global config about sharing postgresql-run socket #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FxKu merged 3 commits into from
Jan 2, 2023
Merged

polish global config about sharing postgresql-run socket #2155

FxKu merged 3 commits into from
Jan 2, 2023

Conversation

@FxKu
Copy link
Member

@FxKu FxKu commented Jan 2, 2023 •
edited
Loading

Follow up to #962 which we have just merged.

  • Call the feature share_pgsocket_with_sidecars everywhere. Golang name will be SharePgSocketWithSidecars.
  • Move it to the right alphabetical place in CRD schema
  • Cover it also in helm chart
  • Extend documentation
  • Provide unit test

@FxKu FxKu added this to the 1.9 milestone Jan 2, 2023
@jopadi
Copy link
Member

jopadi commented Jan 2, 2023

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Jan 2, 2023

👍

@FxKu FxKu merged commit d7e1fb5 into master Jan 2, 2023
@FxKu FxKu deleted the sidecar-socket-pr-roundup branch January 2, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@FxKu @jopadi