set wal_level for streams in statefulSet sync #2187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flow when adding streams in the manifest is as follows:
SNYC 1:
syncStatefulSetcompares desired (manifest) and effective Patroni config and restarts podssyncStreams(callingsyncPostgresConfig) setswal_level: logicalwhich requires a Postgres restart only happening insyncStatefulSet, exitsyncStreamsearlySNYC 2:
syncStatefulSetcompares desired (manifest) and effective Patroni config and restarts podssyncStreams(callingsyncPostgresConfig) setswal_level: logicalbut config is already updated - no restart required anymore, proceed with publications and slotssyncStreams(callingsyncPostgresConfig) syncing replication slots in Patroni configThe PR proposes the following refactoring:
SNYC 1:
syncStatefulSetsetswal_level: logicalif streams are defined and then compares desired (manifest) and effective Patroni config (callingsyncPatroniConfig) and restarts podssyncStreamsexpecteswal_levelto be already configured and callssyncPatroniConfigto reflect the slots required for streams in Patroni configIt brings the following advantages:
streamswere added to the manifest - no need to wait for next SYNCsyncStatefulSetandsyncStreamssharing the same code for syncing Postgres configsyncStatefulSetdue to new functions makes the code easier to understand