feat(coprocessor): implement a retry mechanism for pbs computations #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goshawk-3
force-pushed
the
georgi/sns/minor-fixes
branch
3 times, most recently
from
4dd0220 to
b33d326
Compare
rudy-6-4
reviewed
Nov 5, 2025
rudy-6-4
reviewed
Nov 5, 2025
rudy-6-4
reviewed
Nov 5, 2025
rudy-6-4
previously approved these changes
Nov 5, 2025
Contributor
rudy-6-4
left a comment
rudy-6-4
left a comment
There was a problem hiding this comment.
Can a small test be added ? Otherwise a e2e run in PR comment gives more confidence to reviewer.
Contributor
Author
We'll probably need to mock the squash_noise call to simulate erroneous behavior and also enforce a DB insert-query failure but that's not trivial. Let me think about it. |
goshawk-3
force-pushed
the
georgi/sns/minor-fixes
branch
from
b0f0036 to
5e9ea06
Compare
PBS computation can be in one of the following states: - completed - squash_noise finished and the ct128 was inserted into the DB - TransientErr - squash_noise finished but the ct128 couldn't be inserted - PermanentErr - squash_noise computation failed. An infinite retry is done only for TransientErr
goshawk-3
force-pushed
the
georgi/sns/minor-fixes
branch
from
5e9ea06 to
7e7c3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://github.com/zama-ai/fhevm-internal/issues/542
PBS computation can be in one of the following states:
squash_noisecomputation failed ordecompress_ctfailedAn infinite retry is done only for Transient Err
Additionally, both squash_noise and decompress_ct are wrapped to return an error if they would otherwise panic. This is done to avoid livelocks similar to the one noticed time ago in zkproof worker here