Skip to content

Conversation

Sumitds074
Copy link
Contributor

<This PR makes small improvements to the README.md:

  • Corrected "Javascript" → "JavaScript"
  • Changed "best performances" → "best performance"
  • Removed unwanted ">"
  • Clarified Rust version requirement with example check

These are minor documentation fixes to improve clarity and readability.

Copy link

cla-bot bot commented Sep 2, 2025

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @Sumitds074 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@Sumitds074
Copy link
Contributor Author

Signed again and created a new pull request. Hope the bot does recognize this time that the CLA is signed.

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 2, 2025
Copy link

cla-bot bot commented Sep 2, 2025

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fixes !

Before we can merge this we need your commits to comply with the "conventional commit" convention: https://www.conventionalcommits.org/en/v1.0.0/
For example, it could be docs: fix typos and improve clarity in README.md.

Please also rebase and squash them so there is only one commit left.

#### FAQ
**Is Zama’s technology free to use?**
>Zama’s libraries are free to use under the BSD 3-Clause Clear license only for development, research, prototyping, and experimentation purposes. However, for any commercial use of Zama's open source code, companies must purchase Zama’s commercial patent license.
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is on purpose, could you please restore it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the requested line and squashed into one commit. Thanks!

@nsarlin-zama
Copy link
Contributor

It looks like you made a mistake in your rebase; the commit now contains too many changes!

@IceTDrinker
Copy link
Member

It looks like you made a mistake in your rebase; the commit now contains too many changes!

@Sumitds074 did you have a chance to fix your PR ?

@IceTDrinker
Copy link
Member

No answer from author, I will recreate this by attributing the co-auhtored-by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants