fix(gpu): avoid out of memory when benchmarking throughput #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
reviewed
Sep 8, 2025
tfhe-benchmark/src/utilities.rs
Outdated
| // This should ensure that operations with PBS count more than the number of blocks | ||
| // squared will have only half of the minimum elements to avoid out of memory errors. | ||
| let min_elements = if op_pbs_count > num_block as u64 * num_block as u64 { | ||
| (elements_per_wave * min_num_waves / 2) as u64 |
Contributor
There was a problem hiding this comment.
We should check if this is enough to have all the "all precision" bench pass, because ilog2 uses more memory than mul I think.
Member
Author
There was a problem hiding this comment.
yup, i am trying to run the benchmarks now
Member
Author
There was a problem hiding this comment.
it failed before that, i will try with 1/3, otherwise i will return to our original 200 default in those cases, since we know that one worked well
guillermo-oyarzun
force-pushed
the
go/fix/fix-bench-mul
branch
7 times, most recently
from
978011b to
88b1c79
Compare
guillermo-oyarzun
force-pushed
the
go/fix/fix-bench-mul
branch
6 times, most recently
from
98e1447 to
7c9750b
Compare
guillermo-oyarzun
force-pushed
the
go/fix/fix-bench-mul
branch
from
7c9750b to
178678a
Compare
agnesLeroy
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: