Skip to content

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Sep 24, 2025

Build the site using version 24.
Replace deprecated node-sass with sass and migrate accordingly.
Update workflows to use 24 and update the action setup-node to latest version.

@psiinon
Copy link
Member

psiinon commented Sep 24, 2025

Logo
Checkmarx One – Scan Summary & Details9749b1af-0dc5-421b-93eb-2a9a5b6ad6a2

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH Missing User Instruction /Dockerfile: 1
detailsA user should be specified in the dockerfile, otherwise the image will run as root
ID: xjh6FmzedxJTGgNHNNEZ1vQERtY%3D
MEDIUM Not Using JSON In CMD And ENTRYPOINT Arguments /Dockerfile: 21
detailsEnsure that we are using JSON in the CMD and ENTRYPOINT Arguments
ID: 456naiVa0dsvU%2BQypjXlYw78fVk%3D
Fixed Issues (18)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
CRITICAL CVE-2018-11499 Npm-node-sass-9.0.0
HIGH CVE-2017-12963 Npm-node-sass-9.0.0
HIGH CVE-2017-12964 Npm-node-sass-9.0.0
HIGH CVE-2018-11694 Npm-node-sass-9.0.0
HIGH CVE-2018-11698 Npm-node-sass-9.0.0
HIGH CVE-2018-19827 Npm-node-sass-9.0.0
HIGH CVE-2022-26592 Npm-node-sass-9.0.0
HIGH Missing User Instruction /Dockerfile: 1
MEDIUM CVE-2018-19797 Npm-node-sass-9.0.0
MEDIUM CVE-2018-20190 Npm-node-sass-9.0.0
MEDIUM CVE-2018-20821 Npm-node-sass-9.0.0
MEDIUM CVE-2018-20822 Npm-node-sass-9.0.0
MEDIUM CVE-2019-18797 Npm-node-sass-9.0.0
MEDIUM CVE-2019-18799 Npm-node-sass-9.0.0
MEDIUM CVE-2019-6283 Npm-node-sass-9.0.0
MEDIUM CVE-2019-6284 Npm-node-sass-9.0.0
MEDIUM CVE-2019-6286 Npm-node-sass-9.0.0
MEDIUM Not Using JSON In CMD And ENTRYPOINT Arguments /Dockerfile: 21

Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@psiinon
Copy link
Member

psiinon commented Sep 25, 2025

now has a conflict

Build the site using version 24.
Replace deprecated `node-sass` with `sass` and migrate accordingly.
Update workflows to use 24 and update the action `setup-node` to latest
version.

Signed-off-by: thc202 <[email protected]>
@thc202 thc202 marked this pull request as ready for review September 25, 2025 08:25
@psiinon psiinon merged commit 799ac37 into zaproxy:main Oct 1, 2025
3 checks passed
@thc202 thc202 deleted the node24 branch October 1, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants