Skip vendored gem files #329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing gems using bundler on a CI system the gems end up in the vendor/bundle folder pr default and these files are not supposed to be included in the package, so they should be skipped. Also locally if installing gems in vendor/ I get a "Too many open files" error as each AppFile is opened upon instantiation. Some systems will not the path be changed: ruby/setup-ruby#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐕
/cc @zendesk/dingo
Description
Skip files in vendor just as files in tmp are skipped.
When installing gems using bundler on a CI system the gems end up in the vendor/bundle folder pr default and these files are not supposed to be included in the package, so they should be skipped. Also locally if installing gems in vendor/ I get a "Too many open files" error as each AppFile is opened upon instantiation.
Before merging this PR
Risks