Skip to content

Conversation

@conner-zepben
Copy link

Description

Task

There are no other dependencies for this project other than the ones that will get installed as a result of executing the commands added to the github action steps.

We are adding 2 new steps to precede the build steps for various npm pipelines which will execute a default linting of eslint (where that fails, it will execute the repository-specific lint script for that codebase and see if that passes).

Associated tasks

Other npm repositories referencing these workflows may need to be tested to ensure that they pass linting. This is a part of our hackathon ideas for July 2024.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • [ ] I have updated the changelog.
  • [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

Breaking changes would be if there are node repositories that currently do not pass linting and may require modification in order to finalize the workflow.

…itory level linting using npm run

Signed-off-by: conner-zepben <[email protected]>
@conner-zepben conner-zepben requested a review from alourie July 10, 2024 06:40
@ryanjcoleman
Copy link
Member

Task linked: DEV-998 Implement code linting in CI

Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
@conner-zepben conner-zepben self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants