-
Notifications
You must be signed in to change notification settings - Fork 0
Linting Integration for ESLint #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
conner-zepben
wants to merge
34
commits into
main
Choose a base branch
from
chore/DEV-998-linting-integrations-npm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itory level linting using npm run Signed-off-by: conner-zepben <[email protected]>
Member
|
Task linked: DEV-998 Implement code linting in CI |
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Signed-off-by: conner-zepben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task
There are no other dependencies for this project other than the ones that will get installed as a result of executing the commands added to the github action steps.
We are adding 2 new steps to precede the build steps for various npm pipelines which will execute a default linting of eslint (where that fails, it will execute the repository-specific lint script for that codebase and see if that passes).
Associated tasks
Other npm repositories referencing these workflows may need to be tested to ensure that they pass linting. This is a part of our hackathon ideas for July 2024.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
[ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.Documentation
[ ] I have updated the changelog.[ ] I have updated any documentation required for these changes.Breaking Changes
Breaking changes would be if there are node repositories that currently do not pass linting and may require modification in order to finalize the workflow.