Skip to content

Conversation

@vincewhite
Copy link
Member

Description

Adds the transformerTapSettings field to the workpackage class. This optional field determines what set distribution transformer tap settings are applied from an external source during [opendss]model generation.

Associated tasks

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes. Didn't find any

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Probably not backwards compatible depending on what tries to deserialise the workpackage grpc message.

@ryanjcoleman
Copy link
Member

@zarakay zarakay merged commit 13416db into main May 1, 2025
3 checks passed
@zarakay zarakay deleted the DEV-2625-Add_transformer_taps_settings branch May 1, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants