Skip to content

Conversation

@vincewhite
Copy link
Member

@vincewhite vincewhite commented Aug 6, 2025

Description

Update to support customer/node level results

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE. I didn't pull out the generator_config_to_json method 🤷‍♀️
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

New functionality. Shouldn't break existing code.

@ryanjcoleman
Copy link
Member

Task linked: DEV-2970 Customer Level Load Flow Results

@vincewhite vincewhite force-pushed the DEV-2970-update_for_customer_level_results branch 2 times, most recently from 84ce930 to 37bf437 Compare August 15, 2025 04:01
@vincewhite vincewhite force-pushed the DEV-2970-update_for_customer_level_results branch 2 times, most recently from f82f353 to 6049a3d Compare August 22, 2025 01:31
Signed-off-by: vince <[email protected]>
@vincewhite vincewhite force-pushed the DEV-2970-update_for_customer_level_results branch from 6049a3d to bbebd59 Compare August 22, 2025 01:32
@vincewhite vincewhite marked this pull request as ready for review August 22, 2025 01:33
Copy link
Contributor

@chestm007 chestm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what could have been...

@vincewhite vincewhite merged commit 5725cf8 into main Aug 25, 2025
4 checks passed
@vincewhite vincewhite deleted the DEV-2970-update_for_customer_level_results branch August 25, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants