Skip to content

Conversation

@vincewhite
Copy link
Member

@vincewhite vincewhite commented Sep 30, 2025

Description

Added optional field inverterControlConfig to ModelConfig. This PVVoltVARVoltWattConfig allows the configuration of advanced inverter control profiles.

ALSO:

TimePeriod no longer truncates the start_time and end_time to midnight(00:00:00). TimePeriod will now preserve arbitrary start and end times to minute precision.

Associated tasks

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.
Probably not

Signed-off-by: vince <[email protected]>
Signed-off-by: vince <[email protected]>
@ryanjcoleman
Copy link
Member

@vincewhite vincewhite force-pushed the DEV-4192-support-advanced-pv-in-workpackage-request branch from 1783df8 to 4e00036 Compare September 30, 2025 04:16
@vincewhite vincewhite force-pushed the DEV-4192-support-advanced-pv-in-workpackage-request branch from 4e00036 to 7de94c8 Compare September 30, 2025 05:10
@vincewhite vincewhite marked this pull request as ready for review October 1, 2025 05:03
Signed-off-by: vince <[email protected]>
@vincewhite vincewhite force-pushed the DEV-4192-support-advanced-pv-in-workpackage-request branch 2 times, most recently from 4535182 to 3ad4b29 Compare October 2, 2025 02:15
@vincewhite vincewhite force-pushed the DEV-4192-support-advanced-pv-in-workpackage-request branch from 3ad4b29 to 30e4ece Compare October 2, 2025 02:19
@kgreav kgreav merged commit b9c6033 into main Oct 2, 2025
4 checks passed
@kgreav kgreav deleted the DEV-4192-support-advanced-pv-in-workpackage-request branch October 2, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants