Skip to content

Conversation

@vincewhite
Copy link
Member

@vincewhite vincewhite commented Oct 7, 2025

Description

Refactors the following work package request fields to snake case:
beforeCutOffProfile -> before_cut_off_profile
afterCutOffProfile -> after_cut_off_profile

Associated tasks

NA

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Breaking existing code setting these fields in the work package request will need to be updated.

Signed-off-by: vince <[email protected]>
@ryanjcoleman
Copy link
Member

@vincewhite vincewhite changed the title [DEV-4267] Update Inverter ontrol config names [DEV-4267] Update Inverter control config names Oct 7, 2025
@vincewhite vincewhite requested a review from chestm007 October 8, 2025 00:19
Signed-off-by: vince <[email protected]>
@vincewhite vincewhite force-pushed the DEV-4267-Update_invert_control_config branch from f1bb59a to 5e77677 Compare October 8, 2025 23:22
@PradipKafleDev PradipKafleDev merged commit 0e8b62a into main Oct 8, 2025
4 checks passed
@PradipKafleDev PradipKafleDev deleted the DEV-4267-Update_invert_control_config branch October 8, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants