Skip to content

Conversation

@roberto-marquez
Copy link
Member

Description

The generationSpec property in an opendss model was changed from an object to a string but the EAS client was still trying to subselect properties within an object causing it to fail.

Associated tasks

NONE

Test Steps

Use the 'async_get_paged_opendss_models' function in the eas client. It works now.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

It is a breaking change because now you get a string instead of an object but the breaking change happened in the backend. This is just a bug fix to put the client in line with the backend.

…ec' property of an opendss model because the backend is now returning a string instead of an object.

Signed-off-by: Roberto Marquez <[email protected]>
@ryanjcoleman
Copy link
Member

kgreav
kgreav previously approved these changes Oct 16, 2025
Signed-off-by: Roberto Marquez <[email protected]>
@kgreav kgreav merged commit 7be7503 into main Oct 16, 2025
4 checks passed
@kgreav kgreav deleted the DEV-4333-fix-get-opendss-models branch October 16, 2025 04:40
kgreav pushed a commit that referenced this pull request Oct 16, 2025
…enerationSpec' property of an opendss model because the backend is now returning a string instead of an object. (#50)

Signed-off-by: Roberto Marquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants