Avoid invalid gcc 14.3 warning about array bounds in mbedtls_xor #73
Conversation
There was a problem hiding this comment.
Could you rather first make a PR in upstream Mbed TLS and then cherry pick it here?
|
|
Thanks! If you want to get this merged here before it's merged upstream then please add a reference to the upstream PR (e.g. PR #) in the commit message. Otherwise we can just wait and cherry pick the upstream commit (with |
It's blocking SDK version 0.18, so we should probably not wait (the fix is pretty easy to review in isolation). |
The combination of the multi-byte loop with the single byte loop confuses GCC 14.3's array bounds checker. When the loop size is constant, check to see if it is a multiple of the multi-byte size and bail early. As this will be evaluated at compile time, there should be no run-time cost. This change has been submitted upstream: Mbed-TLS/mbedtls#10318 Signed-off-by: Keith Packard <[email protected]>
The combination of the multi-byte loop with the single byte loop confuses GCC 14.3's array bounds checker. When the loop size is constant, check to see if it is a multiple of the multi-byte size and bail early. As this will be evaluated at compile time, there should be no run-time cost.