Add Basic support for Microchip SAM D5X/E5X Family devices #93450

ArunMCHP · 2025-07-21T14:07:08Z

This PR adds initial support for Microchip’s SAM D5x/E5x family of SoCs, along with board support for the SAM E54 Xplained Pro development kit (ATSAME54-XPRO). It includes the basic SoC integration, devicetree files, and minimal configuration needed to bring up the board with a working UART console.

Associated pull request for the addition of the SAM D5x/E5x devices to hal_microchip:
zephyrproject-rtos/hal_microchip#33

The naming convention of driver files and device organization is as per the RFC : #92168

github-actions · 2025-07-21T14:07:59Z

Hello @ArunMCHP, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-07-21T14:08:58Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_microchip	zephyrproject-rtos/hal_microchip@`32a79d4`	zephyrproject-rtos/hal_microchip@`97485f8` (`master`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm · 2025-07-22T06:24:34Z

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

+config SOC_FAMILY
+	default "microchip_sam_d5x_e5x" if SOC_FAMILY_MCHP_SAM_D5X_E5X


names do not match

Renamed to mchp_sam_d5x_e5x

nordicjm · 2025-07-22T06:26:56Z

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

+config SOC_SERIES_REVISION_N
+	bool
+	depends on SOC_FAMILY_MCHP_SAM_D5X_E5X
+
+config SOC_SERIES_REVISION
+	string
+	default "n" if SOC_SERIES_REVISION_N
+	default ""
+	depends on SOC_FAMILY_MCHP_SAM_D5X_E5X


do not think this should be here @tejlmand

Removed this.

nordicjm · 2025-07-22T06:27:09Z

soc/microchip/sam/sam_d5x_e5x/samd51/Kconfig.soc

+config SOC_SERIES
+	default "samd51" if SOC_SERIES_MCHP_SAMD51


does not match

Renamed to mchp_samd51.

nordicjm · 2025-07-22T06:27:14Z

soc/microchip/sam/sam_d5x_e5x/samd51/Kconfig.soc

+
+config SOC_SERIES
+	default "samd51" if SOC_SERIES_MCHP_SAMD51
+


Suggested change

nordicjm · 2025-07-22T06:27:22Z

soc/microchip/sam/sam_d5x_e5x/samd51/Kconfig.soc

+config SOC_ATSAMD51P20A
+	bool
+	select SOC_SERIES_MCHP_SAMD51
+


Suggested change

nordicjm · 2025-07-22T06:29:48Z

drivers/pinctrl/Kconfig.mchp

+config PINCTRL_MCHP_PORT_ID_U2210_2_2_0
+	bool
+	default n
+	help
+	  Internal flag to enable PORT ID U2210_2_2_0 support.


put this in an if so it's not bleeding into other devices

We moved this symbol to family kconfig.soc, and kept inside if SOC_FAMILY_MCHP_SAM_D5X_E5X.
path : soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

nordicjm · 2025-07-22T06:29:56Z

drivers/pinctrl/Kconfig.mchp

+
+config PINCTRL_MCHP_PORT_ID_U2210_2_2_0
+	bool
+	default n


Suggested change

default n

fix in whole PR

moved to family kconfig.soc and fixed.

nordicjm · 2025-07-22T06:30:21Z

drivers/serial/Kconfig.mchp

+	select PINCTRL
+	select UART_MCHP_SERCOM_ID_U2201_5_0_0 if SOC_FAMILY_MCHP_SAM_D5X_E5X
+	help
+		This option enables the USART driver for Microchip sercom-g1 IPs.


help text indent in 1x tab followed by 2x spaces

nordicjm · 2025-07-22T06:30:46Z

boards/microchip/sam/sam_e54_xpro/doc/img/atsam_e54_xpro.webp

reduce resolution and put through https://tinypng.com/

Reduced resolution using https://tinypng.com/ and updated.

nordicjm · 2025-07-22T06:30:49Z

boards/microchip/sam/sam_e54_xpro/doc/img/atsam_e54_xpro_pinout.webp

reduce resolution and put through https://tinypng.com/

Reduced resolution using https://tinypng.com/ and updated.

parthitce

Please re-order the commits.

parthitce · 2025-07-23T07:18:54Z

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

+# List of Peripheral IPs available in SOC_FAMILY_MCHP_SAM_D5X_E5X family
+if SOC_FAMILY_MCHP_SAM_D5X_E5X
+
+config UART_MCHP_SERCOM_U2201_5_0_0


this shall be part of board IMO

Here, we define peripheral IP versions as Kconfig symbols at the SoC family level, since these IPs are shared across multiple SoCs in the SAM D5X/E5X family. Keeping them here avoids duplication when supporting multiple boards, for example, if we later add support for the SAME54 Curiosity board, we won’t need to redefine the same IP symbols again.

parthitce · 2025-07-23T07:18:59Z

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

+	help
+	  Enable SERCOM UART peripheral IP version 5.0.0 (U2201).
+
+config PINCTRL_MCHP_PORT_U2210_2_2_0


Refer the response to previous comment.

parthitce · 2025-07-23T07:19:40Z

soc/microchip/sam/sam_d5x_e5x/common/CMakeLists.txt

+
+zephyr_sources(soc.c)
+
+zephyr_include_directories(.)


no header inside common

Removed zephyr_include_directories(.)

parthitce · 2025-07-23T07:20:01Z

soc/microchip/sam/sam_d5x_e5x/common/CMakeLists.txt

+
+zephyr_include_directories(.)
+
+zephyr_include_directories(${ZEPHYR_BASE}/drivers)


There is no header under drivers

Removed zephyr_include_directories(${ZEPHYR_BASE}/drivers)

parthitce · 2025-07-23T07:20:21Z

soc/microchip/sam/sam_d5x_e5x/common/soc.c

+
+void soc_reset_hook(void)
+{
+	/* Intentionally empty */


then it's not required

parthitce · 2025-07-23T07:28:36Z

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

+		/* Validate subsystem. */
+		if (CLOCK_SUCCESS != clock_check_subsys(subsys)) {
+			ret_val = -ENOTSUP;
+			break;


Refer the response to previous comment

parthitce · 2025-07-23T07:29:22Z

drivers/clock_control/Kconfig.mchp

+# Common features for all SOC families
+if CLOCK_CONTROL_MCHP
+
+config CLOCK_CONTROL_MCHP_GET_RATE


why is this special ?

parthitce · 2025-07-23T07:29:35Z

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

+	do {
+		/* Check if turning on all clocks is requested. */
+		if (subsys.val == (uint32_t)CLOCK_CONTROL_SUBSYS_ALL) {
+			break;


parthitce · 2025-07-23T07:30:03Z

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

+	default:
+		LOG_ERR("Unsupported mclkbus");
+		break;
+	}


new line, applies everywhere

New line provided.

parthitce · 2025-07-23T07:30:49Z

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

+	bool is_wait = false;
+	uint32_t on_timeout_ms = 0;
+
+	subsys.val = (uint32_t)sys;


move to declaration + init form

Update west.yml for SAM_D5X_E5X Device family pack Signed-off-by: Arunprasath P <[email protected]>

Adds initial SoC-level support for the Microchip SAM D5x and E5x series, including SoC definition files. Signed-off-by: Arunprasath P <[email protected]>

Add minimal set of binding parameters for clock_control driver. Signed-off-by: Sunil Abraham <[email protected]>

Add clock control driver with minimal functionality. Implement basic on, off, get_status and get_rate API. Signed-off-by: Sunil Abraham <[email protected]>

Add binding parameters for Microchip Pinctrl Port G1 IP Signed-off-by: Mohamed Azhar <[email protected]>

Add pinctrl driver for Microchip Port G1 Peripheral IPs Signed-off-by: Mohamed Azhar <[email protected]>

Add minimal set of binding parameters for sercom uart driver. Signed-off-by: Sunil Abraham <[email protected]>

Add uart driver with minimal features. Implement polling receive and transmit functionality. Signed-off-by: Sunil Abraham <[email protected]>

Adds common and SoC-specific .dtsi files for the Microchip SAM D5x/E5x family. These files define core peripherals, address maps, and interrupt controller structure shared across the SAM D5x/E5x variants. Signed-off-by: Arunprasath P <[email protected]>

Add initial support for the Microchip SAM E54 Xplained Pro board (ATSAME54-XPRO). Product page: https://www.microchip.com/en-us/development-tool/atsame54-xpro Signed-off-by: Arunprasath P <[email protected]>

sonarqubecloud · 2025-07-23T18:29:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: Pinctrl area: Flash area: UART Universal Asynchronous Receiver-Transmitter labels Jul 21, 2025

zephyrbot added area: Clock Control platform: Microchip MEC Microchip MEC Platform labels Jul 21, 2025

zephyrbot requested review from albertofloyd, dcpleung, de-nordic, gmarull, jvasanth1, mnkp, nandojve, nordic-krch, pdgendt, rghaddab, stephanosio and VenkatKotakonda July 21, 2025 14:08

zephyrbot assigned nordic-krch Jul 21, 2025

github-actions bot added manifest manifest-hal_microchip DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 21, 2025

nordicjm requested changes Jul 22, 2025

View reviewed changes

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 5e8b12a to 4981667 Compare July 22, 2025 14:19

ArunMCHP requested a review from nordicjm July 22, 2025 14:37

parthitce requested changes Jul 23, 2025

View reviewed changes

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 4981667 to 5b8d763 Compare July 23, 2025 15:06

west.yml: Update west.yml for SAM_D5X_E5X dfp

4983255

Update west.yml for SAM_D5X_E5X Device family pack Signed-off-by: Arunprasath P <[email protected]>

ArunMCHP and others added 9 commits July 23, 2025 23:27

soc: microchip: add support for SAM D5x/E5x SoC series

832eedc

Adds initial SoC-level support for the Microchip SAM D5x and E5x series, including SoC definition files. Signed-off-by: Arunprasath P <[email protected]>

bindings: clock_control: microchip: clock bindings for SAM D5x/E5x

f89214b

Add minimal set of binding parameters for clock_control driver. Signed-off-by: Sunil Abraham <[email protected]>

drivers: clock_control: microchip: clock support for SAM D5x/E5x

3565ebf

Add clock control driver with minimal functionality. Implement basic on, off, get_status and get_rate API. Signed-off-by: Sunil Abraham <[email protected]>

bindings: pinctrl: microchip: pinctrl bindings for Port G1 IP

4b1d77e

Add binding parameters for Microchip Pinctrl Port G1 IP Signed-off-by: Mohamed Azhar <[email protected]>

drivers: pinctrl: microchip: add pinctrl driver for Port G1 IP

4a5caf6

Add pinctrl driver for Microchip Port G1 Peripheral IPs Signed-off-by: Mohamed Azhar <[email protected]>

bindings: sercom_g1_uart: microchip: uart bindings for sercom g1 IPs

303d38d

Add minimal set of binding parameters for sercom uart driver. Signed-off-by: Sunil Abraham <[email protected]>

drivers: uart: microchip: add minimal support for sercom uart g1 IPs

5e81251

Add uart driver with minimal features. Implement polling receive and transmit functionality. Signed-off-by: Sunil Abraham <[email protected]>

boards: microchip: add SAM E54 Xplained Pro board support

eac3759

Add initial support for the Microchip SAM E54 Xplained Pro board (ATSAME54-XPRO). Product page: https://www.microchip.com/en-us/development-tool/atsame54-xpro Signed-off-by: Arunprasath P <[email protected]>

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 5b8d763 to eac3759 Compare July 23, 2025 18:04

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Jul 23, 2025

ArunMCHP requested a review from parthitce July 23, 2025 18:15

		config SOC_FAMILY
		default "microchip_sam_d5x_e5x" if SOC_FAMILY_MCHP_SAM_D5X_E5X


		zephyr_include_directories(.)

		zephyr_include_directories(${ZEPHYR_BASE}/drivers)


		zephyr_sources(soc.c)

		zephyr_include_directories(.)

Add Basic support for Microchip SAM D5X/E5X Family devices #93450

Are you sure you want to change the base?

Add Basic support for Microchip SAM D5X/E5X Family devices #93450

Conversation

ArunMCHP commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArunMCHP Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parthitce left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArunMCHP Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading

ArunMCHP Jul 22, 2025 •

edited

Loading

ArunMCHP Jul 23, 2025 •

edited

Loading