Switch bootloaders to picolibc #93470
Conversation
zephyrbot
added
platform: Raspberry Pi Pico
zephyrbot
requested review from
de-nordic,
rghaddab,
soburi,
ThreeEights and
yonsch
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 3 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-trusted-firmware-m
manifest-hal_rpi_pico
manifest-cmsis_6
DNM (manifest)
keith-packard
force-pushed
the
picolibc-modules
branch
from
35eaec3 to
4235ab6
Compare
zephyrbot
added
area: Settings
zephyrbot
requested review from
d3zd3z,
ithinuel,
kartben,
nashif,
tomi-font,
valeriosetti,
Vge0rge and
wearyzen
| @@ -363,7 +363,7 @@ manifest: | |||
| groups: | |||
| - tee | |||
| - name: trusted-firmware-m | |||
| revision: 021e2bbd50c215e41710a72e05abce3224f074a7 | |||
| revision: pull/134/head | |||
There was a problem hiding this comment.
This is queued for merging but not yet upstream.
Does this mean that you have submitted the changes upstream? (if so please link to that in the TF-M PR commits)
There was a problem hiding this comment.
Just to the Zephyr repository (shown in the revision above). I suppose I should attempt to figure out how to submit upstream to tf-m.
There was a problem hiding this comment.
Ok, that looks extremely complicated. Can we get some review here first and see if this change is reasonable?
There was a problem hiding this comment.
Sure. I can also submit the changes upstream for you if needed.
Though I'm not qualified to review the changes in zephyrproject-rtos/trusted-firmware-m#134. I mentioned the PR to upstream maintainers so I hope they can also chime in to tell their opinions. (cc @Anton-TF @adeaarm)
There was a problem hiding this comment.
If you're willing to shepherd the change upstream, that would be helpful (especially given their email-based submission process).
There was a problem hiding this comment.
ok, the trusted-firmware-m changes are actually passing tests with both Zephyr SDK version 0.17 (+ a few patches) and SDK version 0.18 (alpha4 + a few patches). I think they're ready for review.
There was a problem hiding this comment.
I still find the commit message (This is queued for merging but not yet upstream.) a tad confusing, please update it when you make changes to the PR.
keith-packard
force-pushed
the
picolibc-modules
branch
from
4235ab6 to
452d9a8
Compare
The picolibc changes were merged upstream; switch to using that revision. As the module now includes flash I/O functions, we don't need our own versions, so remove them. Signed-off-by: Anas Nashif <[email protected]>
Now that rpi_pico can use picolibc, let's switch to it. Signed-off-by: Keith Packard <[email protected]>
This is queued for merging but not yet upstream. Signed-off-by: Keith Packard <[email protected]>
This allows cmsis_6 to compile against picolibc Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
picolibc-modules
branch
from
452d9a8 to
aa05949
Compare
keith-packard
force-pushed
the
picolibc-modules
branch
from
3d8aace to
57a7160
Compare
psa-arch-tests includes device drivers that failed to mark registers with 'volatile'. GCC 14.3 cleverly optimized sequential register accesses using strd/ldrd instructions which caused the drivers to fail. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
picolibc-modules
branch
from
57a7160 to
b8219bb
Compare
|
Switch rpi_pico, trusted-firmware-m and cmsis_6 to use picolibc instead of newlib.