Skip to content

drivers: adc: nrfx_saadc: Remove platform dependencies #93497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jaz1-nordic
Copy link
Contributor

Switch saadc drivers pin definitions for generic ones defined in nrf-saadc.h

Copy link

github-actions bot commented Jul 22, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nordic zephyrproject-rtos/hal_nordic@2f5d4e5 (master) zephyrproject-rtos/hal_nordic#309 zephyrproject-rtos/hal_nordic#309/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nordic DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 22, 2025
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! been waiting a while for this :)

@jaz1-nordic jaz1-nordic force-pushed the nrfx-7708_pin_translation_to_driver branch from c129ecd to 4c7bc60 Compare July 23, 2025 08:35
@decsny decsny removed their request for review July 24, 2025 16:55
@jaz1-nordic jaz1-nordic force-pushed the nrfx-7708_pin_translation_to_driver branch 4 times, most recently from 2608b29 to ba30de0 Compare July 29, 2025 08:16
Update hal_nordic version to have new common analog functionality.

Signed-off-by: Jakub Zymelka <[email protected]>
Remove platform dependencies to make dt-bindings more generic.

Signed-off-by: Jakub Zymelka <[email protected]>
Switch saadc pin definitions for generic ones defined in nrf-saadc.h

Signed-off-by: Jakub Zymelka <[email protected]>
Make the saadc driver more generic by including a generic header file
for analog peripherals and removing platform dependencies.

Signed-off-by: Jakub Zymelka <[email protected]>
Replace the analog pin mapping method with the generic one
from the (LP)COMP driver.

Signed-off-by: Jakub Zymelka <[email protected]>
@jaz1-nordic jaz1-nordic force-pushed the nrfx-7708_pin_translation_to_driver branch from ba30de0 to c680885 Compare July 30, 2025 12:50
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Comparator DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nordic platform: nRF Nordic nRFx platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants