-
Notifications
You must be signed in to change notification settings - Fork 7.9k
west.yml: Bump tf-m with stm32 patches #93520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
west.yml: Bump tf-m with stm32 patches #93520
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
de1ec72
to
f4b0642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good with some comments.
Commit message for "boards: st: b_u585i_iot02a: ns: Redesign flash partitions" should emphasis that the new layout is synced with TF-M flash layout (possibly with a Zephyr/TF-M P-R reference).
Since b_u585i_iot02a board flash layout is changed, a firmware update (e.g. FOTA) will not be able to upgrade a Zephyr v4.2.0 (or older) system to a v4.3.0 (or later) version. Terefore I think it would be nice there are a few words about it in the migration guide file (doc/releases/migration-guide-4.3.rst).
45668a5
to
accb6cb
Compare
Hi @etienne-lms , All tests are passing now. |
Hi @etienne-lms , I was wondering if you had time to check latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late feedback. It would be nice these STM32 TF-M updates land in Zephyr.
Commit "boards: st: b_u585i_iot02a: ns: Redesign flash partitions" removes file
tests/drivers/flash/common/boards/b_u585i_iot02a_stm32u585xx_ns.overlay. Looking at it, I think it's fine: the overlay file was no really needed. Indeed I successfully ran this test on a b_u585i_iot02a board with your patches applied.
I think it would be better to have a short line about that in the commit message so that it's clear the file was intentionally removed and the test is still functional.
A few Minor comments.
I wonder if this commit should also integrate west.yml update, so that all commits in Zephyr Git history are functional, but it's maybe not really required so fine as-is if maintainers are Ok.
36001bb
to
5c80544
Compare
You are right, I miss that! I reorder the commits to fix that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait zephyrproject-rtos/trusted-firmware-m#145 is merged.
doc/releases/migration-guide-4.3.rst
Outdated
This is a breaking change in firmware upgrade (FOTA) will not be able to upgrade an older | ||
Zephyr image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is not clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I drop this sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good now, but I would keep some words to make it clear that this is a breaking change for FOTA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally some hints on how to bring back support would be nice, but I guess it would likely be too long to really fit in the porting guidelines. Maybe should we create a Github issue and put some description here that could be referenced in this porting guide?
(edited) Maybe this could be added later, this P-R could only add few words like: "This change currently prevents upgrade from older Zephyr release images to Zephyr 4.3 release images."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added @etienne-lms words + more details in the TF-M migration/release notes. Possible in #94875 we need to point to some new docs about OTP and #94470 should be in the release notes.
5c80544
to
d595d99
Compare
The S and NS shares the extermal NOR memory. This extracts the external NOR partition definitions from b_u585i_iot02a-common.dtsi and move to b_u585i_iot02a.dts to allow NS software defined their own external partition layout. Signed-off-by: BUDKE Gerson Fernando <[email protected]>
d595d99
to
6aadae9
Compare
This brings many tf-m patches related to stm32 SoCs. It sync stm32 with the vendor mainline patches and add all the necessary pieces to allow STM32U5Axxx SoC work with TF-M. The patch list can be checked in: zephyrproject-rtos/trusted-firmware-m#145 In addition, redesign the b_u585i_iot02a flash partitions. The current b_u585i_iot02a NS flash layout difficult the development of large applications. Since there is an external NOR memory which is already supported by tf-m, this proposes a layout reconfiguration which allows bigger bootloader, S and NS software. With this redesign the overlay in the tests can be safely removed. This new layout is synced with TF-M 2.1.1 mainline, see: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/41126 The bootloader BL2 now will fetch FOTA content from the external memory. Signed-off-by: BUDKE Gerson Fernando <[email protected]>
|
Hi @tomi-font , @etienne-lms , Could you help me to identify what is missing ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main missing part is to wait zephyrproject-rtos/trusted-firmware-m#145 is merged so you can update this P-R with the relevant TF-M Git SHA1 reference in west.yml.
@@ -29,6 +29,11 @@ Kernel | |||
Boards | |||
****** | |||
|
|||
* b_u585i_iot02a/ns: The flash layout was changed to be in sync with the upstream TF-M 2.2.1 board |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* b_u585i_iot02a/ns: The flash layout was changed to be in sync with the upstream TF-M 2.2.1 board | |
* ``b_u585i_iot02a//ns``: The flash layout was changed to be in sync with the upstream TF-M 2.2.1 board |
This patches are necessary to make STM32U5Axxx works with TF-M.
Tested with
press reset button