Skip to content

enable i2c of imx943 #93653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2025
Merged

enable i2c of imx943 #93653

merged 1 commit into from
Aug 16, 2025
+115 −0

Conversation

biwenli
Copy link
Contributor

@biwenli biwenli commented Jul 24, 2025 •
edited
Loading

Enable i2c of imx943

dbaluta
dbaluta previously approved these changes Jul 24, 2025
View reviewed changes
@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from b75f722 to 7624fa7 Compare July 24, 2025 10:10
decsny
decsny requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this new sample is needed at all, it has no code in it and adds no value over just building the shell sample with the i2c shell enabled.

@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from 7624fa7 to 31221a9 Compare July 25, 2025 03:51
@biwenli
Copy link
Contributor Author

biwenli commented Jul 25, 2025 •
edited by dleach02
Loading

I don't think this new sample is needed at all, it has no code in it and adds no value over just building the shell sample with the i2c shell enabled.

It sames with the sample sensor_shell. It's used to test i2c bus and any i2c slave devices on the i2c bus with simplest way. It can be used to detect any i2c slave devices on the bus. It can be used by any platform that include i2c ip.

@decsny
Copy link
Member

decsny commented Jul 28, 2025

I don't think this new sample is needed at all, it has no code in it and adds no value over just building the shell sample with the i2c shell enabled.

It sames with the sample sensor_shell. It's used to test i2c bus and any i2c slave devices on the i2c bus with simplest way. It can be used to detect any i2c slave devices on the bus. It can be used by any platform that include i2c ip.

Well, the sensor shell sample is also unneeded then. But I also see in that sample they put pytest stuff in it to validate the commands actually work. So it should have been a test and not a sample.

@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from 31221a9 to 43c460d Compare July 29, 2025 04:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@biwenli
Copy link
Contributor Author

biwenli commented Aug 7, 2025

@biwenli Could you update doc for the I2C support? Thanks.

sure, updated.

yangbolu1991
yangbolu1991 previously approved these changes Aug 7, 2025
View reviewed changes
@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from 776949d to d7730ae Compare August 8, 2025 03:07
@zephyrbot zephyrbot added area: Samples Samples area: Shell Shell subsystem labels Aug 8, 2025
@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from d7730ae to ae670aa Compare August 8, 2025 03:28
decsny
decsny reviewed Aug 8, 2025
View reviewed changes
boards/nxp/imx943_evk/doc/index.rst Outdated
Comment on lines 72 to 73
I2C
---

Enable lpi2c6 defaultly for M33(In NETC MIX).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not grammatically correct and doesn't need to go in the doc page, its already captured on supported feature table which is generated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not grammatically correct and doesn't need to go in the doc page, its already captured on supported feature table which is generated

sure.

@decsny decsny changed the title Add i2c shell sample and enable i2c of imx943 enable i2c of imx943 Aug 8, 2025
@mmahadevan108
Copy link
Contributor

@biwenli is this dependent on #93760

@biwenli
Copy link
Contributor Author

biwenli commented Aug 11, 2025

@biwenli is this dependent on #93760

@mmahadevan108 ,
No.

@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from ae670aa to ba608f8 Compare August 11, 2025 01:36
dleach02
dleach02 previously approved these changes Aug 13, 2025
View reviewed changes
@dleach02
Copy link
Member

@decsny Can you confirm that your change request was addressed?

@biwenli
boards: nxp: imx943_evk: m33: add i2c support
ebf48ed 
Add i2c support for m33(in NETCMIX) of imx943_evk

Signed-off-by: Biwen Li <[email protected]>
@biwenli biwenli force-pushed the add-i2c-shell-sample-and-enable-i2c-of-imx943 branch from 5c3e1ba to ebf48ed Compare August 14, 2025 02:40
@biwenli biwenli closed this Aug 14, 2025
@biwenli biwenli reopened this Aug 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dleach02 dleach02 requested a review from decsny August 14, 2025 21:34
mmahadevan108
mmahadevan108 reviewed Aug 14, 2025
View reviewed changes
modules/hal_nxp/mcux/mcux-sdk-ng/drivers/drivers.cmake
@@ -186,6 +186,12 @@ endif()
set_variable_ifdef(CONFIG_HAS_MCUX_XCACHE CONFIG_MCUX_COMPONENT_driver.cache_xcache)

if((${MCUX_DEVICE} MATCHES "MIMX9596") OR (${MCUX_DEVICE} MATCHES "MIMX8UD7") OR (${MCUX_DEVICE} MATCHES "MIMXRT118") OR (CONFIG_SOC_MIMX94398) OR (CONFIG_SOC_MIMXRT798S))

if(CONFIG_SOC_MIMX94398_M33)
set(CONFIG_MCUX_COMPONENT_driver.irqsteer_1 ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed if you do not have a dependency on the new irq_steer driver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed if you do not have a dependency on the new irq_steer driver?
This is a irqsteer driver(CONFIG_MCUX_COMPONENT_driver.irqsteer_1) in mcux sdk. It needs to be enabled by default.
The i2c driver(drivers/i2c/i2c_mcux_lpi2c.c) of zephyr will use lpi2c driver(drivers/lpi2c/fsl_lpi2c.c) of mcux sdk,
the lpi2c driver of mcux sdk will can api EnableIRQ(drivers/common/fsl_common_arm.h) of mcux sdk,
EnableIRQ -> IRQSTEER_EnableInterrupt

image

mmahadevan108
mmahadevan108 requested changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification on a change

@kartben kartben merged commit 0e830e8 into zephyrproject-rtos:main Aug 16, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben left review comments

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@dleach02 dleach02 dleach02 approved these changes

@decsny decsny decsny approved these changes

@dbaluta dbaluta dbaluta left review comments

@yangbolu1991 yangbolu1991 yangbolu1991 left review comments

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

@manuargue manuargue Awaiting requested review from manuargue

@nashif nashif Awaiting requested review from nashif

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@Zhiqiang-Hou Zhiqiang-Hou Awaiting requested review from Zhiqiang-Hou

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels
area: Samples Samples area: Shell Shell subsystem platform: NXP MPU platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@biwenli @decsny @yangbolu1991 @mmahadevan108 @dleach02 @dbaluta @kartben @zephyrbot