-
Notifications
You must be signed in to change notification settings - Fork 7.8k
soc: silabs: Add RAIL Multiprotocol support #93892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soc: silabs: Add RAIL Multiprotocol support #93892
Conversation
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes and 12 blob changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot for this!
soc/silabs/Kconfig
Outdated
@@ -310,4 +310,13 @@ config SOC_GECKO_CUSTOM_RADIO_PHY | |||
management, sending and receiving packets on radio phy. User has | |||
to provide the radio_config.c and radio_config.h files for the phy. | |||
|
|||
config SOC_GECKO_RAIL_MULTIPROTOCOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like for new Kconfig options that are used to select HAL content to be in the HAL Kconfig files. We also have a desire to split options targeting Gecko SDK from options targeting Simplicity SDK, as these SDKs will diverge over time.
I propose adding config SILABS_SISDK_RAIL_MULTIPROTOCOL
in modules/hal_silabs/simplicity_sdk/Kconfig
, and a similar option in gecko
.
The existing SOC_GECKO
options will need to be disentangled over time and migrated to the HAL Kconfig files, but that's out of scope for this PR IMO.
561392d
to
1b318b8
Compare
@asmellby made those requested Kconfig option changes, and also fixed a pre-existing bug with blob importing on series 1 / gecko_sdk devices. Side note: Bluetooth HCI doesn't actually seem to be implemented on any Series 1 boards in Zephyr, I'll consider adding that in a seperate set of PRs. |
1b318b8
to
26ed65f
Compare
fbb6b20
to
c250f4c
Compare
c250f4c
to
4662908
Compare
@@ -34,4 +34,12 @@ config RAIL_PA_ENABLE_CALIBRATION | |||
calibration. This option is enabled by default, and is recommended for all | |||
Series 2 devices. | |||
|
|||
config SILABS_SISDK_RAIL_MULTIPROTOCOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use SILABS_SISDK_
prefix for the features but other Rail related options are just prefixed by RAIL_
. We should keep consistency (I am not opposed to rename RAIL_
options, but it would break compatibility).
@loopj there's a conflict in |
Adds Kconfig options to enable RAIL Multiprotocol support Signed-off-by: James Smith <[email protected]>
Enables RAIL Multiprotocol support by linking against the multiprotocol RAIL library blob when `CONFIG_SILABS_GECKO_RAIL_MULTIPROTOCOL` or `CONFIG_SILABS_SISDK_RAIL_MULTIPROTOCOL` are enabled. Signed-off-by: James Smith <[email protected]>
Bugfix to correct broken binary blobs path when using the Gecko SDK. Signed-off-by: James Smith <[email protected]>
Set `SL_RAIL_LIB_MULTIPROTOCOL_SUPPORT` to `1` when Rail Multiprotocol Kconfig is enabled. This is required to run the Bluetooth multiprotocol initialization code during `sl_btctrl_init`. Signed-off-by: James Smith <[email protected]>
4662908
to
cc130b3
Compare
@asmellby @jerome-pouiller can you please discuss and give me some concrete guidance on the following
In the meantime I've rebased from main to avoid the west.yml conflict so we should be good to go there. Thanks! |
|
Let's keep the current code until a real policy emerge.
The right thing to do is to rename the |
In progress: #94151 |
Removed the "DNM (manifest)" label after verifying that the added blobs are compliant with Zephyr policy. |
This PR adds support for the Silicon Labs RAIL Multiprotocol library, which provides coexistence and arbitration between multiple wireless protocols (for example, Bluetooth LE and a proprietary 2.4 GHz stack) on Gecko SoCs.
Depends on zephyrproject-rtos/hal_silabs#126