MAINTAINERS: Add hal_xhsc maintainers and collaborators #94941
Conversation
XH-YongbingLiu
force-pushed
the
xhsc-MAINTAINERS
branch
from
1616783 to
cbaea68
Compare
The updates for hal_xhsc can be found in this pull request: PR for hal_xhsc |
|
This comment is intended to increase the visibility of this PR. (_) |
MAINTAINERS.yml
Outdated
| - greya5 | ||
| - JamieTx | ||
| - TrackingRobot | ||
| files: [] |
There was a problem hiding this comment.
Why are there no files associated with this module?
There was a problem hiding this comment.
“Files” should be “modules/Kconfig.xhsc.” The reason I set this value to “[]” is that the CI check (check_compliance.py) will fail with “no such file...”.
Actually, the PR (#94044), which includes all the files needed by the XHSC MCU, will not trigger this issue. But we need access first to update zephyrproject-rtos/hal_xhsc. So I submitted this PR.
Should I ignore the compliance check error and set it back to “modules/Kconfig.xhsc”?
There was a problem hiding this comment.
Thank you for your suggestion. I reduced the number of users in this module to the minimum required. After this PR is merged, I will modify #94044.
There was a problem hiding this comment.
It seems that the rules for checking MAINTAINERS.yml have changed. Therefore, I added the lost file Kconfig.xhsc to this PR. However, the check still failed with:
Error: levizh does not have needed access level to zephyrproject-rtos/zephyr
Error: TrackingRobot does not have needed access level to zephyrproject-rtos/zephyr
Error: Process completed with exit code 1.
These errors not appeared at previous.
May I ask what is the right way to get write access for zephyrproject-rtos/hal_xhsc?
There was a problem hiding this comment.
The maintainer file check workflow was previously broken and is now fixed and working as expected.
It looks like neither @levizh nor @TrackingRobot is currently a "Contributor with Triage permission level," which is a prerequisite for becoming a Collaborator or a Maintainer.
Contributors are promoted to the Collaborator role by adding the GitHub user name to one or more collaborators sections of the MAINTAINERS File in the Zephyr repository.
So they first need to become a "Contributor with Triage permission level" by filing a nomination (see below).
Contributors who show dedication and skill are granted the Triage permission level to the Zephyr GitHub repository.
You may nominate yourself, or another GitHub user, for promotion to the Triage permission level by creating a GitHub issue, using the nomination template.
This, however, often requires 3-5 merged pull requests, which neither you seems to have.
For now, my suggestion is to create pull requests to the hal_xhsc module containing the changes necessary for #94044 and ping one of the admins to get it merged (you can ping me too).
There was a problem hiding this comment.
Hi stephanosio, thank you very much for your detailed and patient reply. I have submitted the hal_xhsc PR
There was a problem hiding this comment.
Hi stephanosio, thank you very much for your detailed and patient reply. I have submitted the hal_xhsc PR
There was a problem hiding this comment.
Hi @stephanosio, shall I temporarily add you as a maintainer for the 'West project: hal_xhsc' in MAINTAINERS.yml?
This is because the CI check in PR #94044 require us to add our HAL as a West project. However, none of us has the necessary qualifications.
XH-YongbingLiu
force-pushed
the
xhsc-MAINTAINERS
branch
2 times, most recently
from
87876cf to
f2237c0
Compare
In order to pass compliance check, add Kconfig.xhsc as the minimal required for MAINTAINERS change. Signed-off-by: Yongbing Liu <[email protected]>
…_xhsc This commit to get the access for zephyrproject-rtos/hal_xhsc. Therefore there no files associated with this module. And this module will be Completed in zephyrproject-rtos#94044. Signed-off-by: Yongbing Liu <[email protected]>
XH-YongbingLiu
force-pushed
the
xhsc-MAINTAINERS
branch
from
f2237c0 to
84bc33d
Compare
|
Add levizh as maintainers, add Pengbiao12345, ETRD, greya5, JamieTx, TrackingRobot as collaborators for hal_xhsc.
The GitHub issue for creating the
hal_xhscmodule is available #86804. Thehal_xhscrepository can be found hal_xhsc