Use TARGETS_REGULAR if the recursive flag is not set #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The program currently stores all targets into `TARGETS_RECURSIVE` even
if the `--recursive` flag is not set. This causes the program to
incorrectly snapshot only the most-ancestral datasets in the list. For
example, the following invocation would only snapshot datasets `a` and
`b`:
$ zfs-snapshot-auto a a\child1 a\child2 b b\child1 b\child2
Instead, we should be storing each valid dataset in `TARGETS_REGULAR`
so that they can be backed up individually. This commit tests wether
the flag is set before deciding whih variable to update.
Fixes: zfsonlinux#83
|
Thanks for submitting this patch. Would really appreciate getting this merged after all this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program currently stores all targets into
TARGETS_RECURSIVEevenif the
--recursiveflag is not set. This causes the program toincorrectly snapshot only the most-ancestral datasets in the list. For
example, the following invocation would only snapshot datasets
aandb:Instead, we should be storing each valid dataset in
TARGETS_REGULARso that they can be backed up individually. This commit tests wether
the flag is set before deciding whih variable to update.
Fixes: #83