TLS: use distinct ciphersuites and extensions for TLS 1.2 and TLS 1.3 #24316
+98
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The added |
|
In my branch I have the entire Client being non-generic, including the init function. Since TLS client is a leaf node I can port that work to be mergeable before the whole sub-project is finished. |
|
(for context, this bug is blocking adding a tarball mirror; see ziglang/www.ziglang.org#492.) |
|
The problem is the retry logic (jedisct1@a9c9e83) . |
… 1.3 Do not try to use TLS 1.3-specific ciphersuites and extensions with TLS 1.2. And the other way round. If a TLS 1.3 handshake fails, retry with TLS 1.2. This fixes connections with hosts such as ziglang.freetls.fastly.net
mlugg
added a commit
to ziglang/www.ziglang.org
that referenced
this pull request
Jul 2, 2025
Minimizing the amount of code running on the website machine is important to avoid potential security vulnerabilities. Since we now need to fetch Zig (rather than it being preinstalled), also update `check-mirrors` to the latest Zig dev version. We'll want to do this soon anyway due to ziglang/zig#24316 blocking #492.
mlugg
added a commit
to ziglang/www.ziglang.org
that referenced
this pull request
Jul 2, 2025
Minimizing the amount of code running on the website machine is important to avoid potential security vulnerabilities. Since we now need to fetch Zig (rather than it being preinstalled), also update `check-mirrors` to the latest Zig dev version. We'll want to do this soon anyway due to ziglang/zig#24316 blocking #492.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to use TLS 1.3-specific ciphersuites and extensions with TLS 1.2. And the other way round.
If a TLS 1.3 handshake fails, retry with TLS 1.2.
This fixes connections with hosts such as ziglang.freetls.fastly.net