-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: init x86_16 arch via CBE #25691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
914acf1
55c0693
9d3bd3c
104c272
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3081,6 +3081,11 @@ pub const cpu = struct { | |
| .xsaveopt, | ||
| }), | ||
| }; | ||
| pub const @"i86": CpuModel = .{ | ||
| .name = "i86", | ||
| .llvm_name = null, | ||
| .features = featureSet(&[_]Feature{}), | ||
| }; | ||
|
Comment on lines
+3084
to
+3088
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops, I didn't catch this earlier. The way to add new CPUs to these files is to modify |
||
| pub const @"i386": CpuModel = .{ | ||
| .name = "i386", | ||
| .llvm_name = "i386", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -223,6 +223,13 @@ pub const CallingConvention = union(enum(u8)) { | |
| x86_vectorcall: CommonOptions, | ||
| x86_interrupt: CommonOptions, | ||
|
|
||
| // Calling conventions for the `x86_16` architecture. | ||
|
|
||
| x86_16_cdecl: CommonOptions, | ||
| x86_16_stdcall: CommonOptions, | ||
| x86_16_regparmcall: CommonOptions, | ||
| x86_16_interrupt: CommonOptions, | ||
|
|
||
| // Calling conventions for the `aarch64` and `aarch64_be` architectures. | ||
| aarch64_aapcs: CommonOptions, | ||
| aarch64_aapcs_darwin: CommonOptions, | ||
|
|
@@ -523,6 +530,10 @@ pub const AddressSpace = enum(u5) { | |
| fs, | ||
| ss, | ||
|
|
||
| // x86_16 extra address spaces. | ||
| /// Allows addressing the entire address space by storing both segment and offset. | ||
| far, | ||
|
Comment on lines
+533
to
+535
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we have precedent for |
||
|
|
||
| // GPU address spaces. | ||
| global, | ||
| constant, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the question is what compilers support, not what the architecture supports.
Which might actually be an argument for moving
supportsAddressSpacetostd.zig.target... but that's a problem for another day.