Fix stale reference bug in std.zig.system.resolveTargetQuery
#25713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Oct 27, 2025
|
Actually, now that I look at this a bit closer... there is indeed a stack UAF bug here, but I think the solution isn't to heap-allocate; rather, I think we should just throw away any non-
|
Instead of duplicating the prerelease and build components, we now ignore them altogether. This is implemented in Target.Query.parseVersion, which now additionally discards the prerelease and build components.
SeanTUT
force-pushed
the
target-resolve-safety-patch
branch
from
78ed81b to
f2f5a20
Compare
This was removed while implementing the ignoring of prerelease and build components, but currently it is incorrect to leave out
…tut/zig into target-resolve-safety-patch
alexrp
reviewed
Oct 27, 2025
alexrp
reviewed
Oct 27, 2025
Now the test ensures that the function returns an error rather than discarding the components
alexrp
reviewed
Oct 28, 2025
Co-authored-by: Alex Rønne Petersen <[email protected]>
alexrp
approved these changes
Oct 28, 2025
TibboddiT
pushed a commit
to TibboddiT/zig
that referenced
this pull request
Oct 28, 2025
…ng#25713) Co-authored-by: Alex Rønne Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
std.zig.resolveTargetQuerydetects the native OS version, anySemanticVersioncontained in the return value would use a stack buffer for the "pre" and "build" fields. This would result in a stale reference being returned from the function. To remedy this, an additional allocator parameter was added to the function.