-
Notifications
You must be signed in to change notification settings - Fork 874
Add Namron 4512772 8-button Zigbee remote #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated code to address ruff/PEP8 feedback from CI.
- Added docstrings
- Fixed imports and punctuation
- Reformatted for compliance
Updated code to address ruff/PEP8 feedback from CI. - Added docstrings - Fixed imports and punctuation - Reformatted for compliance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated code to address ruff/PEP8 feedback from CI.
- Added docstrings
- Fixed imports and punctuation
- Reformatted for compliance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4185 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 340 342 +2
Lines 10993 11001 +8
=======================================
+ Hits 10037 10045 +8
Misses 956 956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the PR! We're migrating all new quirks to the much-simplified v2 interface. Since your quirk just adds automation triggers, you can use this very similar quirk as a template and strip off all of the matching code present in this v1 quirk: https://github.com/zigpy/zha-device-handlers/blob/be5f15c312e2243529810803f032debde2b58ae6/zhaquirks/legrand/wirelessswitch.py |
Proposed change
Add custom ZHA quirk for Namron 4512772 8-button Zigbee switch.
channel_1
tochannel_8
).Additional information
Namron 4512772
(8-button Zigbee switch)NAMRON AS
Checklist
pre-commit
checks pass / the code has been formatted using Black