Skip to content

Conversation

laity-w-sudo
Copy link

@laity-w-sudo laity-w-sudo commented Aug 14, 2025

Proposed change

add Sonoff SNZB-02P Temperature And Humidity Sensor

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.05%. Comparing base (a5c5914) to head (d53f5fa).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/sonoff/snzb02p.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4263   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         350      351    +1     
  Lines       11601    11617   +16     
=======================================
+ Hits        10679    10694   +15     
- Misses        922      923    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly
Copy link
Contributor

puddly commented Aug 14, 2025

There's no need to open a second pull request (#4262), you can just update the original one until it's in a good state. We squash the changes at the end.

As I mentioned in the earlier PR, please fill out the pull request template completely and match the existing code style for the repo (e.g. https://github.com/zigpy/zha-device-handlers/blob/a5c5914d9e2f0742ba9e7472991a661de22ff889/zhaquirks/sonoff/trvzb.py).

@laity-w-sudo
Copy link
Author

There's no need to open a second pull request (#4262), you can just update the original one until it's in a good state. We squash the changes at the end.

As I mentioned in the earlier PR, please fill out the pull request template completely and match the existing code style for the repo (e.g. https://github.com/zigpy/zha-device-handlers/blob/a5c5914d9e2f0742ba9e7472991a661de22ff889/zhaquirks/sonoff/trvzb.py).

Hello, I have made the necessary revisions as per your instructions and resubmitted the document. If you have time, please take a look at it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants