Skip to content

Improve mixWithOthers, background music will be lower while sound playing. #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve mixWithOthers, background music will be lower while sound playing. #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions android/src/main/java/com/zmxv/RNSound/RNSoundModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ public class RNSoundModule extends ReactContextBaseJavaModule implements AudioMa
Boolean mixWithOthers = true;
Double focusedPlayerKey;
Boolean wasPlayingBeforeFocusChange = false;
AudioManager audioManager;

public RNSoundModule(ReactApplicationContext context) {
super(context);
this.context = context;
this.category = null;
audioManager = (AudioManager) context.getApplicationContext().getSystemService(context.AUDIO_SERVICE);
}

private void setOnPlay(boolean isPlaying, final Double playerKey) {
Expand Down Expand Up @@ -204,7 +206,7 @@ protected MediaPlayer createMediaPlayer(final String fileName) {
}
return mediaPlayer;
}

File file = new File(fileName);
if (file.exists()) {
mediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC);
Expand Down Expand Up @@ -237,12 +239,14 @@ public void play(final Double key, final Callback callback) {

// Request audio focus in Android system
if (!this.mixWithOthers) {
AudioManager audioManager = (AudioManager) context.getSystemService(Context.AUDIO_SERVICE);

audioManager.requestAudioFocus(this, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN);

this.focusedPlayerKey = key;
} else {
audioManager.requestAudioFocus(this, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK);
player.setVolume(0.2f, 0.2f);
}
this.focusedPlayerKey = key;

final RNSoundModule that = this;

player.setOnCompletionListener(new OnCompletionListener() {
boolean callbackWasCalled = false;
Expand All @@ -251,6 +255,11 @@ public void play(final Double key, final Callback callback) {
public synchronized void onCompletion(MediaPlayer mp) {
if (!mp.isLooping()) {
setOnPlay(false, key);

if (that.mixWithOthers && key == that.focusedPlayerKey) {
audioManager.abandonAudioFocus(that);
}

if (callbackWasCalled) return;
callbackWasCalled = true;
try {
Expand Down Expand Up @@ -303,7 +312,6 @@ public void stop(final Double key, final Callback callback) {

// Release audio focus in Android system
if (!this.mixWithOthers && key == this.focusedPlayerKey) {
AudioManager audioManager = (AudioManager) context.getSystemService(Context.AUDIO_SERVICE);
audioManager.abandonAudioFocus(this);
}

Expand All @@ -328,7 +336,6 @@ public void release(final Double key) {

// Release audio focus in Android system
if (!this.mixWithOthers && key == this.focusedPlayerKey) {
AudioManager audioManager = (AudioManager) context.getSystemService(Context.AUDIO_SERVICE);
audioManager.abandonAudioFocus(this);
}
}
Expand Down