Skip to content

a11y: Keyboard navigation; aria attributes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a11y: Keyboard navigation; aria attributes #49

wants to merge 1 commit into from

Conversation

@doubleedesign
Copy link

@doubleedesign doubleedesign commented Jul 22, 2022 •
edited
Loading

Accessibility enhancements:

  • Add tabindex to the list items to make them navigable with a keyboard
  • Trigger the onClick function when the enter/return key is pressed
  • Add aria-expanded and aria-hidden attributes to the button and list respectively; toggle their values when the list opens/closes

@doubleedesign doubleedesign changed the title Make dropdown work with keyboard navigation a11y: Keyboard navigation; aria attributes Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@doubleedesign