- 
                Notifications
    
You must be signed in to change notification settings  - Fork 18
 
Add Helm Chart for EclipseMosquitto – Track 2 (ZopDev SoC 2025) #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Helm Chart for EclipseMosquitto – Track 2 (ZopDev SoC 2025) #252
Conversation
        
          
                charts/mosquitto/Chart.yaml
              
                Outdated
          
        
      | @@ -0,0 +1,10 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to use apiVersion v2
| size: 1Gi | ||
| 
               | 
          ||
| # Authentication | ||
| auth: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should now take password as input it shoudl be generated as radmon string inside helm chart
| 
           implemented the changes you advised @PiyushSingh-ZS , can you test and let me know if any changes are needed?  | 
    
| 
           hey @PiyushSingh-ZS @arunesh-j can you kindly review this PR its been 2 weeks since last review ...  | 
    
| 
           @Ashish-Kumar-Dash testing the helm chart, will update you with review and test results  | 
    
| 
           @PiyushSingh-ZS  @arunesh-j  Kindly review and let me know if any more changes are needed,  | 
    
          
 Hey can you kindly provide an update on this? What was the result? @PiyushSingh-ZS  | 
    
| @@ -0,0 +1,11 @@ | |||
| diskSize : "10Gi" | |||
| 
               | 
          |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a field "version" so that we can use the same image with different tag
| spec: | ||
| containers: | ||
| - name: mosquitto | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not present in the values.yaml
only add version as dynamic and add the image statically
| 
           can you kindly review again  | 
    
| 
           @arunesh-j @PiyushSingh-ZS FYI ^  | 
    
| 
           @Ashish-Kumar-Dash Thanks for your update, will test the chart and let you know for the changes ASAP.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly check all the templates in the chart so that if any values that are referred, which is not present in the values.yaml can be updated with the default values.
Also add a configmap which should have all the connection details and if there is any password for connection that can be added in the secrets.
        
          
                charts/mosquitto/templates/pvc.yaml
              
                Outdated
          
        
      | @@ -0,0 +1,18 @@ | |||
| {{- if .Values.persistence.enabled }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not present in values.yaml
we can remove this check and make it enabled in default
| @@ -0,0 +1,15 @@ | |||
| {{- if .Values.auth.enabled }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not present in values.yaml
we can remove this check and make it enabled in default
| 
           hey @arunesh-j @gizmo-rt   I have updated with default values & presets, kindly review again at your convenience & let me know if any changes are needed,  | 
    
| 
           kidnly review pls @arunesh-j  | 
    
| 
           kindly review @arunesh-j  | 
    
Description
This pull request introduces a fully-featured, production-ready Helm chart for deploying the Eclipse Mosquitto MQTT broker.
Problem Addressed
The repository lacked a Helm chart for Mosquitto. This PR provides a modular, configurable, and Kubernetes-native way to deploy Mosquitto using Helm.
Features Added
Deployment,Service,ConfigMap,Secret,PersistentVolumeClaimmosquitto.confinjection via ConfigMaptest-values.yamlfor dry-run verificationNOTES.txtfor post-install user guidanceType of Change
Checklist
test-values.yaml, GitHub CI)README.md,NOTES.txt)helm lintpasses without errors@arunesh-j Kindly review and let me know if any changes are needed, If validation via helm and Kubernetes is required kindly inform
Thank you