Skip to content

Conversation

@GitGitro
Copy link

@GitGitro GitGitro commented Aug 1, 2024

Hi! i've merged various pull requests in order to bring the project a bit up to date and fix some bugs

all credits are in the commits as i have cherry-picked but here are the authors:
@azumukupoe
@uuupah
@diogosena
@D3viantS4ge
@ryansereno

this fixes:
#131 #32 #74 #64 #65 #38 #25 #24

@GitGitro GitGitro changed the title Hi! Merge various prs Aug 1, 2024
@diogosena
Copy link

Please include this commit diogosena@d3eea11

ext = EXT_MAP.get(Zotify.CONFIG.get_download_format().lower())

output_template = output_template.replace("{artist}", fix_filename(artists[0]))
output_template = output_template.replace("{artists}", fix_filename(', '.join(artists)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the delimiter should be configurable via --md-artistdelimiter?

@thegreatestgiant
Copy link

@GitGitro I used your version and whenever it comes across a song that I already have in my playlist, it downloads it again but adds a _1

###   SKIPPING: Panic! At The Disco - Girls _ Girls _ Boys (SONG ALREADY EXISTS)   ###

Panic! At The Disco - Girls _ Girls _ Boys: 100%|████████████████████████████████████████████████████████████████▉| 3.52M/3.53M [00:21<00:00, 169kB/s]
                                                                                                                                                      ###   Downloaded "Panic! At The Disco - Girls _ Girls _ Boys" to "Creative title/Panic! At The Disco - Girls _ Girls _ Boys_1.ogg" in 21s (plus 5s converting)   ###

                                                                                                                                                      
###   SKIPPING: Panic! At The Disco - The Ballad of Mona Lisa (SONG ALREADY EXISTS)   ###

Panic! At The Disco - The Ballad of Mona Lisa: 100%|█████████████████████████████████████████████████████████████▉| 3.92M/3.92M [00:26<00:00, 156kB/s]
                                                                                                                                                      ###   Downloaded "Panic! At The Disco - The Ballad of Mona Lisa" to "Creative title/Panic! At The Disco - The Ballad of Mona Lisa_1.ogg" in 26s (plus 3s converting)   ###

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants