Exposing Whitelisted Protocols to User Settings

[jonassorgenfrei]

What's this PR do?

It exposes the whitelisted protocols list so users can add additional protocols that should not use the link wrapper.
Adresses Issue: #1284

You have tested this PR on:

• Windows
• Linux/Ubuntu

[alya]

Thanks! Could you please update your commit message to match the commit style guidelines?

[andersk]

Do not close and reopen multiple pull requests for the same thing, even to fix the commit structure; you can always fix the commit structure by rebasing and force-pushing your existing branch.

[jonassorgenfrei]

I adjusted the commit message to match the style guide.
Yeah i messed i my repo on the first PR by directly implementing it on the main branch and by messing up my rebasing. Next time i know better :)

[jonassorgenfrei]

Is there anything left to do on this PR?

[jonassorgenfrei]

@andersk @timabbott can you take a look if there's anything missing here that avoid a merge?

[timabbott]

I think we'd need documentation for how users can decide which protocols they can safely add there.

[jonassorgenfrei]

@timabbott

I think we'd need documentation for how users can decide which protocols they can safely add there.

Totally makes sense, i'm just unsure where to document the setting.json 's new key.
I could put it in the docs but would probably have to add a new .md file like desktop-app-settings.md?
On Zulip Help i didn't find a section about the setting.json.

Could you point me to where i shall add the information then i'm happy to add it there too

[timabbott]

A new file seems fine. I'd call it customize-link-protocols.md

[jonassorgenfrei]

Allright i added a customize-link-protocols.md to docs/howto :)
Hope that's fine.

[jonassorgenfrei]

@timabbott could you may be take another look on the PR?

Everything should be there now, would be cool if we can merge it in main,
as i often had to fix merge conflicts with the latest changes to keep this pr uptodate.