Enable fullscreen video on macOS #1456
Open
+19
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, videos embedded in Zulip Desktop could not enter fullscreen mode.
This was caused by the app’s permission handler not explicitly granting the
fullscreen
permission.Solution
Updated the
ipcRenderer.on("permission-request")
handler to grantfullscreen
permission in addition to existing ones (e.g., notifications).This ensures video players and other elements can properly request fullscreen.
Fixes: #1409
Screen Capture:-
Screen.Recording.2025-09-14.at.5.46.14.PM.mov
Embedding Check:-
Screen.Recording.2025-09-14.at.6.18.38.PM.mov
Platforms Tested
Self-review checklist
Code changes are minimal and scoped to permission handling.
Commit message explains the fix clearly.
Verified fullscreen works on macOS video players (tested on YouTube and Zulip-embedded media).
Tested on Windows/Linux to confirm no regressions.