Skip to content

Render KaTeX by default #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Render KaTeX by default #1720

merged 1 commit into from
Jul 22, 2025

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Jul 19, 2025

Fixes #46. (By enabling the TeX support whose substance was added over a number of preceding PRs.)

Here's a version of the commit I've included in each release recently, atop (previous versions of) #1559, to enable our KaTeX support. Now that #1559 and its preceding PRs (#1698, and others before that) are merged to main, this is ready to go to main too.

This was a minimal version for the release, just flipping the flag's default to true. But in general we should remove experimental flags from the codebase as soon as they're no longer relevant, to keep complexity from building up. (See the doc on [GlobalSettingType.experimentalFeatureFlag].) @rajveermalviya would you write a follow-up commit that removes this flag entirely, and cleans up the logic elsewhere which that makes possible to clean up?

5287d39 content: Render KaTeX by default, the way we have in recent releases

This is cherry-picked from commits we included in each of the last
several releases, starting with 8f37237 in v0.0.31.

This is cherry-picked from commits we included in each of the last
several releases, starting with 8f37237 in v0.0.31.
@gnprice gnprice marked this pull request as ready for review July 22, 2025 00:51
@gnprice
Copy link
Member Author

gnprice commented Jul 22, 2025

@rajveermalviya would you write a follow-up commit that removes this flag entirely, and cleans up the logic elsewhere which that makes possible to clean up?

I've filed #1728 to track this follow-up task.

Merging this change now, in the interest of further syncing up the main branch with what we've had in recent releases.

@gnprice gnprice merged commit b073c6b into zulip:main Jul 22, 2025
1 check passed
@gnprice gnprice deleted the pr-katex-enable branch July 22, 2025 00:53
@gnprice gnprice mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeX in the message list
2 participants