Fix/toggle dimensions 1636 #1723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a custom FigmaSwitch widget to precisely match the design specifications for the 'Invisible mode' toggle, resolving the dimension mismatch
loveucifer
force-pushed
the
fix/toggle-dimensions-1636
branch
8 times, most recently
from
b4f33cf to
aa97842
Compare
loveucifer
force-pushed
the
fix/toggle-dimensions-1636
branch
from
aa97842 to
5e2b6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1631
This pull request resolves the issue where the "Invisible mode" toggle switch did not match the Figma design specifications. The standard Flutter Switch widget does not provide the necessary customization options to achieve the required dimensions.
to address this, this PR introduces a new custom widget, FigmaSwitch, which is built from the ground up to precisely match the specified dimensions for both its on and off states.
Changes I made""
New FigmaSwitch Widget: highly-customizable w, highly-customizable switch widget that accurately reflects the Figma design for the "Invisible mode" toggle.
New FigmaSwitchListTile Widget: A ListTile that incorporates the FigmaSwitch for easy integration into settings pages.
Settings Page Integration: The "Invisible mode" setting now uses the new FigmaSwitchListTile to ensure it matches the design.
Testing""
Navigate to the settings page.
See the "Invisible mode" toggle switch.
Verify that its dimensions match the Figma specifications in both the "on" and "off" states.
On: 28px by 48px, with a 10px radius thumb.
Off: 26px by 46px, with a 7px radius thumb.
Confirm that the toggle switch functions correctly, updating the user's presence setting.
Hope this resolves the issue
also attaching before and after screenshots
BEFORE
AFTER
