Skip to content

Fixes #1808: Added UI Feedback on Poll Delay #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #1808: Added UI Feedback on Poll Delay #1830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 22 additions & 26 deletions lib/widgets/poll.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,32 +87,28 @@ class _PollWidgetState extends State<PollWidget> {
crossAxisAlignment: CrossAxisAlignment.baseline,
textBaseline: localizedTextBaseline(context),
children: [
GestureDetector(
// TODO: Implement feedback when the user taps the button
onTap: () => _toggleVote(option),
behavior: HitTestBehavior.translucent,
child: ConstrainedBox(
constraints: const BoxConstraints(minWidth: 44, minHeight: 44),
child: Padding(
// For accessibility, the touch target is padded to be larger
// than the vote count box. Still, we avoid padding at the
// start because we want to align all the poll options to the
// surrounding messages.
padding: const EdgeInsetsDirectional.only(
end: 5, top: verticalPadding, bottom: verticalPadding),
child: Container(
// Inner padding preserves whitespace even when the text's
// width approaches the button's min-width (e.g. because
// there are more than three digits).
padding: const EdgeInsets.symmetric(horizontal: 4),
decoration: BoxDecoration(
color: theme.colorPollVoteCountBackground,
border: Border.all(color: theme.colorPollVoteCountBorder),
borderRadius: BorderRadius.circular(3)),
child: Center(
child: Text(option.voters.length.toString(),
style: textStyleBold.copyWith(
color: theme.colorPollVoteCountText, fontSize: 20))))))),
ConstrainedBox(
constraints: const BoxConstraints(minWidth: 44, minHeight: 44),
child: Padding(
padding: const EdgeInsetsDirectional.only(
end: 5, top: verticalPadding, bottom: verticalPadding),
child: Material(
color: Colors.transparent,
child: InkWell(
onTap: () => _toggleVote(option),
child: Ink(
// Inner padding preserves whitespace even when the text's
// width approaches the button's min-width (e.g. because
// there are more than three digits).
padding: const EdgeInsets.symmetric(horizontal: 4),
decoration: BoxDecoration(
color: theme.colorPollVoteCountBackground,
border: Border.all(color: theme.colorPollVoteCountBorder),
borderRadius: BorderRadius.circular(3)),
child: Center(
child: Text(option.voters.length.toString(),
style: textStyleBold.copyWith(
color: theme.colorPollVoteCountText, fontSize: 20)))))))),
Expanded(
child: Padding(
// This and the padding on the vote count box both extend the row
Expand Down