Skip to content

Conversation

rajveermalviya
Copy link
Member

@rajveermalviya rajveermalviya added the maintainer review PR ready for review by Zulip maintainers label Sep 23, 2025
@chrisbobbe chrisbobbe requested a review from gnprice September 23, 2025 21:50
@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Sep 23, 2025
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Sep 23, 2025
@chrisbobbe
Copy link
Collaborator

Sure, LGTM

@gnprice
Copy link
Member

gnprice commented Sep 23, 2025

Thanks for taking care of this! Looks good; merging.

@gnprice gnprice merged commit e6b2297 into zulip:main Sep 23, 2025
1 check passed
@gnprice
Copy link
Member

gnprice commented Sep 24, 2025

I just did some quick experiments on the effect of this PR, while drafting the changelog for the next release. Recording the results here FTR:

It looks like current versions of Android don't yet have the Unicode 17 emoji. So this PR makes those emoji viewable in Zulip, where they otherwise would show up as just a placeholder.

OTOH when it comes to the preceding PR #1835, current Android versions do have the Unicode 16 emoji, so this PR has no effect on those on such devices. (For devices with older versions of Android, it should have an effect similar to what this PR does for Unicode 17.)

Specifically:

  • I sent some test emoji, starting here: #test here > emoji @ 💬
  • On my device (a Pixel 8 with Android 16, recently updated), running a Zulip from main from today, all the emoji displayed just fine. OTOH the device's emoji keyboard only knew about the Unicode 16 examples, not the Unicode 17 examples.
  • On Alya's device, running the current release v30.0.264 (which predates both of these PRs), only the Unicode 16 emoji appeared; the others showed up as placeholders.

(And we use this font in the first place only on Android, not on iOS.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants