Skip to content

test [nfc]: Unmark testFoo functions as async #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

test [nfc]: Unmark testFoo functions as async #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/widgets/emoji_reaction_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ void main() {
for (final emojiset in [Emojiset.text, Emojiset.google]) {
for (final textDirection in TextDirection.values) {
for (final textScaleFactor in kTextScaleFactors) {
Future<void> runSmokeTest(
void runSmokeTest(
String description,
List<Reaction> reactions, {
required List<User> users,
required Map<String, RealmEmojiItem> realmEmoji,
}) async {
}) {
final descriptionDetails = [
displayEmojiReactionUsers ? 'show names when few' : 'no names',
emojiset.name,
Expand Down
14 changes: 7 additions & 7 deletions test/widgets/text_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ void main() {
});

group('weightVariableTextStyle', () {
Future<void> testWeights(
void testWeights(
String description, {
required TextStyle Function(BuildContext context) styleBuilder,
bool platformRequestsBold = false,
required List<FontVariation> expectedFontVariations,
required FontWeight expectedFontWeight,
}) async {
}) {
testWidgets(description, (tester) async {
addTearDown(testBinding.reset);
tester.platformDispatcher.accessibilityFeaturesTestValue =
Expand Down Expand Up @@ -179,13 +179,13 @@ void main() {
});

group('bolderWghtTextStyle', () {
Future<void> testBolderWghtTextStyle(
void testBolderWghtTextStyle(
String description, {
required TextStyle Function(BuildContext context) makeStyle,
bool platformRequestsBold = false,
required double expectedWght,
required FontWeight expectedFontWeight,
}) async {
}) {
testWidgets(description, (tester) async {
addTearDown(testBinding.reset);
tester.platformDispatcher.accessibilityFeaturesTestValue =
Expand Down Expand Up @@ -340,12 +340,12 @@ void main() {
});

group('proportionalLetterSpacing', () {
Future<void> testLetterSpacing(
void testLetterSpacing(
String description, {
required double Function(BuildContext context) getValue,
double? ambientTextScaleFactor,
required double expected,
}) async {
}) {
testWidgets(description, (tester) async {
addTearDown(testBinding.reset);
if (ambientTextScaleFactor != null) {
Expand Down Expand Up @@ -394,7 +394,7 @@ void main() {
});

group('localizedTextBaseline', () {
Future<void> testLocalizedTextBaseline(Locale locale, TextBaseline expected) async {
void testLocalizedTextBaseline(Locale locale, TextBaseline expected) {
testWidgets('gives $expected for $locale', (tester) async {
addTearDown(testBinding.reset);
tester.platformDispatcher.localeTestValue = locale;
Expand Down
4 changes: 2 additions & 2 deletions test/widgets/theme_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ void main() {
group('button text size and letter spacing', () {
const buttonText = 'Zulip';

Future<void> doCheck(
void doCheck(
String description, {
required Widget button,
double? ambientTextScaleFactor,
}) async {
}) {
testWidgets(description, (tester) async {
addTearDown(testBinding.reset);
if (ambientTextScaleFactor != null) {
Expand Down