message: Give access to ChannelStore in outbox-handling logic #1941
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Oct 24, 2025
rajveermalviya
added
integration review
|
Sure, merging. Probably the most efficient way to handle a change like this would be to include the commit in the PR that actually makes use of it, though 🙂 |
We'll use this for zulip#1798 to check whether we're sending a message to an unsubscribed channel.
gnprice
force-pushed
the
pr-outbox-channel-store
branch
from
324ab2b to
9c3e999
Compare
|
Ah yeah, that's reasonable :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll use this for #1798 to check whether we're sending a message to an unsubscribed channel.