On malformed event and /register response, show stack trace to user
#1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI change for @alya's review: left-aligning the body text in dialogs on iOS, per Greg's suggestion:
(Prompted by noticing that the stack traces look bad when center-aligned.) |
rajveermalviya
approved these changes
Oct 27, 2025
rajveermalviya
added
integration review
|
Screenshot looks good to me, thanks! |
We're about to show a stack trace in an error dialog, and it'll be easier to read when start-aligned than center-aligned. Applying it here with DefaultTextStyle, rather than on each Text widget, to avoid repetition, particularly because one caller (of _adaptiveContent) passes multiple Text widgets and we'd have to handle each of those; that's in UpgradeWelcomeDialog.
(The comment about log entries being truncated at 1 kiB is copied from a similar debugLog call.) Issue zulip#1083 isn't completely fixed here; we'd still like to show stack traces for malformed `/register` responses. Fixes-partly: zulip#1083
(Except when we get a SocketException, which is common when the device is asleep.) This includes showing a stack trace when the /register response is malformed, so I think that's the last of zulip#1083, having addressed events in a recent commit. Fixes zulip#890. Fixes zulip#1083.
|
Thanks for taking care of this! Looks good; merging. |
gnprice
force-pushed
the
pr-stack-trace-malformed-response
branch
from
980771d to
cb9c4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890.
Fixes #1083.