Skip to content

homescreen_icon: Change 'globe' to 'list' #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

homescreen_icon: Change 'globe' to 'list' #5532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ade586
homescreen_icon [nfc]: Swap TopTabButton with TopTabButtonGeneral
Nov 3, 2022
eaf8e09
homescreen_icon: Swap icon 'globe' with 'list' for web UI parity.
Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/common/Icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,4 @@ export const IconGroup: SpecificIconType = makeIcon(FontAwesome, 'group');
export const IconPlus: SpecificIconType = makeIcon(Feather, 'plus');
// eslint-disable-next-line react/function-component-definition
export const IconWebPublic: SpecificIconType = props => <ZulipIcon name="globe" {...props} />;
export const IconAllMessages: SpecificIconType = makeIcon(Feather, 'align-left');
12 changes: 9 additions & 3 deletions src/main/HomeScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import LoadingBanner from '../common/LoadingBanner';
import ServerCompatBanner from '../common/ServerCompatBanner';
import ServerPushSetupBanner from '../common/ServerPushSetupBanner';
import { OfflineNoticePlaceholder } from '../boot/OfflineNoticeProvider';
import { IconAllMessages } from '../common/Icons';

const styles = createStyleSheet({
wrapper: {
Expand All @@ -43,12 +44,17 @@ export default function HomeScreen(props: Props): Node {
<SafeAreaView mode="padding" edges={['top']} style={styles.wrapper}>
<OfflineNoticePlaceholder />
<View style={styles.iconList}>
<TopTabButton
name="globe"
<TopTabButtonGeneral
onPress={() => {
dispatch(doNarrow(HOME_NARROW));
}}
/>
>
<IconAllMessages
size={24}
style={{ textAlign: 'center', transform: [{ scaleY: -1 }] }}
color={BRAND_COLOR}
/>
</TopTabButtonGeneral>
<TopTabButton
name="star"
onPress={() => {
Expand Down